dep: cap transformers version due to FSDP bug #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmj
requested changes
Sep 10, 2024
pyproject.toml
Outdated
| @@ -27,7 +27,7 @@ classifiers=[ | |||
| ] | |||
| dependencies = [ | |||
| "numpy>=1.26.4,<2.0", | |||
| "accelerate>=0.20.3,<0.40", | |||
| "accelerate==0.33.0", | |||
There was a problem hiding this comment.
Could we do
"accelerate>=0.20.3,<0.34"
- FSDP bug in accelerate v0.34 Signed-off-by: Anh Uong <anh.uong@ibm.com>
anhuong
force-pushed
the
cap-accelerate
branch
from
27e8d45
to
c968e7a
Compare
aluu317
pushed a commit
to aluu317/fms-hf-tuning
that referenced
this pull request
Sep 13, 2024
- FSDP bug in accelerate v0.34 Signed-off-by: Anh Uong <anh.uong@ibm.com> Signed-off-by: Angel Luu <angel.luu@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
v0.34.0 and v0.34.1 of accelerate has a bug where when training with FSDP, the weight is being flattened and is unable to be loaded. Capping at v0.33 before the change went in and at a verified point.
Related issue number
How to verify the PR
Was the PR tested