Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(DAOs): Add more integration tests for uploadDao, PfileDao, showJobsDao and Upload permissionsDao. #2832

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

valens200
Copy link
Contributor

Description

This pull request introduces integration tests for UploadDao, PfileDao, showJobsDao and UploadPermissionsDao

Changes

  • Improved the current test cases
  • Introduced additional test cases
  • Added documentation on test cases

How to test

  • All tests pass with no issues.

Corresponding issue
CC: @GMishx , @shaheemazmalmmd , @dushimsam , @soham4abc

@shaheemazmalmmd
Copy link
Member

@valens200 This PR deletes src/lib/php/services.xml.in file. that is why the test cases are failing. please add it back

@valens200 valens200 force-pushed the integration_test_no_2 branch 6 times, most recently from 087895a to 0f5e6fa Compare September 24, 2024 04:24
@valens200
Copy link
Contributor Author

@valens200 This PR deletes src/lib/php/services.xml.in file. that is why the test cases are failing. please add it back

Sure.

@valens200 valens200 force-pushed the integration_test_no_2 branch from bc51bdb to 1dc3b39 Compare September 24, 2024 05:38
test(DAOs): added more integration tests for uploadDao, PfileDao, JobsDao and UploadPermissionDao

Update AgentDao.php

Signed-off-by: valens niyonsenga <95166477+valens200@users.noreply.github.com>

test(models): added more test cases for showJobsDAO

fix(dao): fixed indentation in folderDaoTest

refact(models): renamed services.xml to services.xml.in file

fix(dao): removed function empty lines errors

Update .dockerignore

Signed-off-by: valens niyonsenga <95166477+valens200@users.noreply.github.com>

Update .gitignore

Signed-off-by: valens niyonsenga <95166477+valens200@users.noreply.github.com>

test(api): added more unit tests for APIs such as Folder, Group, License and Upload API.

test(models): fixed failing test case
@valens200 valens200 force-pushed the integration_test_no_2 branch from 1dc3b39 to 574b7b6 Compare September 24, 2024 13:34
@shaheemazmalmmd shaheemazmalmmd added needs code review needs test GSOC-24 Label to tag issues and pull request for GSOC 2024 activities labels Sep 30, 2024
Copy link
Member

@Kaushl2208 Kaushl2208 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good :)
Tests working as well

@shaheemazmalmmd shaheemazmalmmd merged commit f63e714 into fossology:master Dec 6, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSOC-24 Label to tag issues and pull request for GSOC 2024 activities needs code review needs test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants