Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(atarashi): Made changes for upload to PyPi #59

Merged
merged 1 commit into from
Oct 22, 2019

Conversation

GMishx
Copy link
Member

@GMishx GMishx commented Aug 22, 2019

Publishing to PyPi

Published atarashi packages to PyPi: https://pypi.org/project/atarashi/

While performing the upload, following issues were faced:

  1. PyPi considers external link dependencies to be unsafe and thus needs to be removed.
  2. Had to make changes in setup.py to match the references set by PyPa.
  3. Update the README to add instructions to install code_comment since it is removed from dependency list.
  4. Bump version to 0.0.10

@GMishx GMishx force-pushed the chore/atarashi/uploadToPyPi branch 2 times, most recently from 4873f7d to da00752 Compare August 22, 2019 06:40
List of changes done:
1. Update version to 0.0.10
2. Fix the entries in setup.py
3. Remove code_comment as external dependency and update README
accordingly.
4. Fix .travis.yml and Dockerfile to install code-comment

Signed-off-by: Gaurav Mishra <mishra.gaurav@siemens.com>
@GMishx GMishx force-pushed the chore/atarashi/uploadToPyPi branch 2 times, most recently from bbe2601 to 0c6bc5d Compare August 22, 2019 10:30
Copy link
Collaborator

@ag4ums ag4ums left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes looks good,

@ag4ums ag4ums merged commit 73563a4 into master Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants