Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump gradle from 3.3.2 to 3.4.1 #2216

Merged
merged 3 commits into from
May 17, 2019
Merged

chore: bump gradle from 3.3.2 to 3.4.1 #2216

merged 3 commits into from
May 17, 2019

Conversation

atm1504
Copy link
Member

@atm1504 atm1504 commented May 17, 2019

Fixes #2212

Changes:
Upgarded the required files.
Fixed the gradle build.
Probably developers have to update to the latest version of the android studio, to prevent any errors from rising.

Screenshots for the change:
Screenshot 2019-05-17 at 3 52 48 PM

dependabot-support and others added 2 commits May 16, 2019 17:15
@dependabot-support
chore(deps): bump gradle from 3.3.2 to 3.4.1
b5540a7 
Bumps gradle from 3.3.2 to 3.4.1.

Signed-off-by: dependabot[bot] <support@dependabot.com>
@atm1504
Gradle updated
6297065
@ci-reporter
Copy link

ci-reporter bot commented May 17, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 6297065. Here's the output:

Run Tests
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

1 similar comment
@ci-reporter
Copy link

ci-reporter bot commented May 17, 2019

The build is failing

✨ Good work on this PR so far! ✨ Unfortunately, the Circle CI build is failing as of 6297065. Here's the output:

Run Tests
> Task :app:preBuild UP-TO-DATE

I'm sure you can fix it! If you need help, don't hesitate to ask a maintainer of the project!

This comment was automagically generated by ci-reporter. If you see a problem, open an issue here.

@atm1504
Copy link
Member Author

atm1504 commented May 17, 2019

@iamareebjamal sir it is properly building in my system. But, dont know why it is failing circleci build online.

@liveHarshit
Copy link
Member

* What went wrong: Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)
I think rebuilding may work.

@atm1504
Copy link
Member Author

atm1504 commented May 17, 2019

* What went wrong: Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)
I think rebuilding may work.

rebuild can only be triggered by a person with write access

@ShridharGoel
Copy link
Member

* What went wrong: Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)
I think rebuilding may work.

rebuild can only be triggered by a person with write access

Just close and reopen the PR to trigger the build

@atm1504 atm1504 closed this May 17, 2019
@atm1504 atm1504 reopened this May 17, 2019
@atm1504 atm1504 closed this May 17, 2019
@atm1504 atm1504 deleted the atm_gradle_updt branch May 17, 2019 10:53
@atm1504 atm1504 restored the atm_gradle_updt branch May 17, 2019 10:54
@atm1504 atm1504 reopened this May 17, 2019
@atm1504
Copy link
Member Author

atm1504 commented May 17, 2019

@ShridharGoel tried but still it donot get triggered

ShridharGoel
ShridharGoel reviewed May 17, 2019
View reviewed changes
gradle/wrapper/gradle-wrapper.properties Outdated
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.10.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-5.1.1-all.zip
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be increased to 5.4.1

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Android studio automatically downloaded it to 5.1.1 version after it was upgraded from 3.3.2 to 3.4.1. So, I don't think it will be much helpful. Also, the build is successfully taking place in my system.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrade to 5.4.1 please. It's the latest version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okk sir.

@iamareebjamal iamareebjamal added the dependencies Pull requests that update a dependency file label May 17, 2019
@iamareebjamal iamareebjamal changed the title chore: bump gradle from 3.3.2 to 3.4.1 … chore: bump gradle from 3.3.2 to 3.4.1 May 17, 2019
@iamareebjamal iamareebjamal merged commit 6b64e03 into fossasia:development May 17, 2019
@auto-label auto-label bot added the chore label May 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShridharGoel ShridharGoel ShridharGoel left review comments

@iamareebjamal iamareebjamal iamareebjamal approved these changes

Assignees
No one assigned
Labels
chore dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@atm1504 @liveHarshit @ShridharGoel @iamareebjamal @dependabot-support