-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ready to merge] Create Event specific Roles, Services, Permissions #885
Merged
rafalkowalski
merged 6 commits into
fossasia:development
from
shivamMg:perm-sys/create-fix
Jun 16, 2016
Merged
[Ready to merge] Create Event specific Roles, Services, Permissions #885
rafalkowalski
merged 6 commits into
fossasia:development
from
shivamMg:perm-sys/create-fix
Jun 16, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shivamMg
changed the title
Create Event specific Roles, Services, Permissions
[Do not merge] Create Event specific Roles, Services, Permissions
Jun 16, 2016
Checks are failing. Please check. |
@mariobehling I'm doing it in three parts:
I'll fix tests all at once. |
Current coverage is 78.99%
@@ development #885 diff @@
=============================================
Files 105 106 +1
Lines 4582 4637 +55
Methods 0 0
Messages 0 0
Branches 0 0
=============================================
+ Hits 3632 3663 +31
- Misses 950 974 +24
Partials 0 0
|
shivamMg
changed the title
[Do not merge] Create Event specific Roles, Services, Permissions
[Ready to merge] Create Event specific Roles, Services, Permissions
Jun 16, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The permissions printed above adhere to #623
Update 2:
User
class has the following methods to check its role:Update 3:
User
class has the following methods to check permissions:e.g.
Service
contains:Role
contains:@rafalkowalski @aditya1702 It's ready to merge. Please review. After you migrate and upgrade, drop_db first and then create_db again. It will create the above mentioned roles and services, and permissions between them.
You can define a user's role for an event in
UsersEventsRoles