fix: Make speaker email nullable

[maze-runnar]

related fossasia/open-event-frontend#5751
Fixes fossasia/open-event-frontend#5342

Checklist

• I have read the Contribution & Best practices Guide and my PR follows them.
• My branch is up-to-date with the Upstream development branch.
• The unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have added necessary documentation (if appropriate)

• All the functions created/modified in this PR contain relevant docstrings.

[maze-runnar]

@iamareebjamal i have set email field to allow null but its still showing
{"errors": [{"status": 422, "source": {"pointer": "/data/attributes"}, "title": "Unprocessable Entity", "detail": "Missing required fields ['email']"}], "jsonapi": {"version": "1.0"}}
in frontend.

[iamareebjamal]

You didn't change schema

[maze-runnar]

You didn't change schema

email = fields.Str(allow_none=True) it is already there in schema

[iamareebjamal]

Please paste the request being sent to the server

[codecov]

Codecov Report

Merging #7469 (334ad08) into development (5e3e8ae) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development    #7469      +/-   ##
===============================================
+ Coverage        65.38%   65.44%   +0.06%     
===============================================
  Files              265      265              
  Lines            13256    13263       +7     
===============================================
+ Hits              8667     8680      +13     
+ Misses            4589     4583       -6     

Impacted Files	Coverage Δ
app/api/helpers/custom_forms.py	100.00% <100.00%> (ø)
app/api/speakers.py	75.00% <100.00%> (+6.42%)	⬆️
app/models/speaker.py	97.61% <100.00%> (ø)
app/api/helpers/permission_manager.py	64.01% <0.00%> (+0.34%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e3e8ae...334ad08. Read the comment docs.

[maze-runnar]

Please paste the request being sent to the server

{"data":{"attributes":{"name":"name_of_speaker","email":null,"photo-url":null,"thumbnail-image-url":null,"icon-image-url":null,"small-image-url":null,"short-biography":"","long-biography":null,"speaking-experience":null,"mobile":null,"location":null,"website":null,"twitter":null,"facebook":null,"github":null,"linkedin":null,"instagram":null,"organisation":"org","is-featured":false,"is-email-overridden":true,"position":"pos","country":null,"city":null,"gender":null,"heard-from":null,"complex-field-values":{}},"relationships":{"user":{"data":{"type":"user","id":"1"}},"event":{"data":{"type":"event","id":"3"}}},"type":"speaker"}}

[iamareebjamal]

It should work. Try required=False in schema as well

[maze-runnar]

ok

[maze-runnar]

email = fields.Str(allow_none=True, required=False) but Not working again.

[iamareebjamal]

Are you sure you are submitting to local server and not production?

[maze-runnar]

yes

[iamareebjamal]

OK, please check other issues for now. I'll test this later

[maze-runnar]

OK, please check other issues for now. I'll test this later

@iamareebjamal what's next here?

[iamareebjamal]

I have fixed it. Pushing soon after writing tests

[iamareebjamal]

@maze-runnar Please test that everything is working

[maze-runnar]

@maze-runnar Please test that everything is working

ok

[maze-runnar]

@iamareebjamal it's working now. But When I included changes of fossasia/open-event-frontend#5751. It is showing
{"errors": [{"status": 422, "source": {"pointer": "/data/attributes"}, "title": "Unprocessable Entity", "detail": "Missing required fields ['email']"}], "jsonapi": {"version": "1.0"}}

[iamareebjamal]

Yes, it is due to email being required in custom forms. Fixing

[iamareebjamal]

Please check now

[iamareebjamal]

@maze-runnar .

[maze-runnar]

it's working correctly.