Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump ember-l10n from 4.1 to 5.1.0 #7971

Closed
wants to merge 2 commits into from

Conversation

progmatic-99
Copy link
Contributor

Fixes #7966

@vercel
Copy link

vercel bot commented Oct 22, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/eventyay/open-event-frontend/3uyhwJTSsfQz8QshaMeENig3X2nn
✅ Preview: Failed

[Deployment for 38918e7 failed]

@pavnesh-c
Copy link
Member

@progmatic-99 is yarn l10n:extract working correctly after this upgrade?

@progmatic-99
Copy link
Contributor Author

@pc-beast Yes, extract command is extracting every new value too. I will look into the failed tests tomorrow.

@pavnesh-c
Copy link
Member

    at new Plugin (/home/pc-beast/Documents/fossasia/open-event-frontend/node_modules/ember-l10n/node_modules/broccoli-plugin/dist/index.js:47:36)
    at new CreateEmberL10nFastBootAssetMap (/home/pc-beast/Documents/fossasia/open-event-frontend/node_modules/ember-l10n/lib/utils/create-fastboot-asset-map.js:9:5)
    at Class.postprocessTree (/home/pc-beast/Documents/fossasia/open-event-frontend/node_modules/ember-l10n/index.js:106:14)
    at /home/pc-beast/Documents/fossasia/open-event-frontend/node_modules/ember-cli/lib/utilities/addon-process-tree.js:6:25
    at Array.reduce (<anonymous>)
    at addonProcessTree (/home/pc-beast/Documents/fossasia/open-event-frontend/node_modules/ember-cli/lib/utilities/addon-process-tree.js:4:32)
    at EmberApp.addonPostprocessTree (/home/pc-beast/Documents/fossasia/open-event-frontend/node_modules/ember-cli/lib/broccoli/ember-app.js:867:12)
    at EmberApp.host.addonPostprocessTree (/home/pc-beast/Documents/fossasia/open-event-frontend/node_modules/ember-auto-import/js/auto-import.js:103:20)
    at EmberApp.toTree (/home/pc-beast/Documents/fossasia/open-event-frontend/node_modules/ember-cli/lib/broccoli/ember-app.js:1690:17)
    at EmberApp.appInstance.toTree (/home/pc-beast/Documents/fossasia/open-event-frontend/node_modules/ember-classic-decorator/node_modules/@embroider/macros/src/ember-addon-main.js:48:35)
-~- (end) -~-
  - errorType: Build Error
  - location:
    - column: [undefined]
    - file: [undefined]
    - line: [undefined]
    - treeDir: [undefined]
  - message: ENOENT: no such file or directory, scandir '/tmp/broccoli-96976D6JKOLVes75E/out-1002-append_ember_auto_import_analyzer//tmp/broccoli-96976D6JKOLVes75E/out-1002-append_ember_auto_import_analyzer'
        at CreateEmberL10nFastBootAssetMap

After looking at the error logs, it seems that it is some problem of dependency resolution in ember-l10n. I tried a few things (including adding dependency mannually), none of them worked. We should try opening issue on ember-l10n according to me. @maze-runnar @codedsun what do you think?

@pavnesh-c
Copy link
Member

@pc-beast In the ember-l10n docs, it is written we no longer have to overwrite the l10n file and need to add configuration differently. Can this error be due to that??

Possible (Very slim chances though).

@codedsun
Copy link
Contributor

@pc-beast Shubham has opened an issue. @progmatic-99 Please add the link here

@progmatic-99
Copy link
Contributor Author

I have opened this on ember-cli, not on ember-l10n.

@progmatic-99
Copy link
Contributor Author

Issue on ember-l10n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump ember-l10n from 4.3.1 to 5.1.0
4 participants