Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ANE-2269] Cut release including themis bug fix #1504

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

nficca
Copy link
Contributor

@nficca nficca commented Feb 11, 2025

Overview

Pull in changes to Themis that fix ANE-2269.

Acceptance criteria

We use the new version of Themis

Testing plan

Do a license scan on a project with the deb+tzdata#debian#12.9$all#0:2024b-0+deb12u1 dep and observe that the public domain license is found.

Risks

Metrics

References

  • ANE-2269: Debian copyright file with clear public-domain license not detected

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).
  • If this PR introduced a user-visible change, I added documentation into docs/.
  • If this PR added docs, I added links as appropriate to the user manual's ToC in docs/README.ms and gave consideration to how discoverable or not my documentation is.
  • If this change is externally visible, I updated Changelog.md. If this PR did not mark a release, I added my changes into an ## Unreleased section at the top.
  • If I made changes to .fossa.yml or fossa-deps.{json.yml}, I updated docs/references/files/*.schema.json AND I have updated example files used by fossa init command. You may also need to update these if you have added/removed new dependency type (e.g. pip) or analysis target type (e.g. poetry).
  • If I made changes to a subcommand's options, I updated docs/references/subcommands/<subcommand>.md.

@nficca nficca requested a review from a team as a code owner February 11, 2025 22:38
@nficca nficca requested a review from csasarak February 11, 2025 22:38
@nficca nficca enabled auto-merge (squash) February 11, 2025 22:39
Copy link
Contributor

@spatten spatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good once you add a link to the PRs in the README

Changelog.md Outdated
@@ -1,6 +1,7 @@
# FOSSA CLI Changelog

## Unreleased
## 3.9.46
- Licensing: Fix a bug where the tzdata debian package copyright was not detected as a public domain license
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a link to the PRs? E.g. for the first one:

- Licensing: Fix a bug where the tzdata debian package copyright was not detected as a public domain license ([#1504](https://github.com/fossas/fossa-cli/pull/1504))

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops; done!

@nficca nficca disabled auto-merge February 11, 2025 22:44
@nficca nficca enabled auto-merge (squash) February 11, 2025 22:55
@nficca nficca merged commit b117f17 into master Feb 11, 2025
18 of 19 checks passed
@nficca nficca deleted the prep-for-release-v3.9.46 branch February 11, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants