Add Mac arm64 executable #1426
Merged
Add Mac arm64 executable #1426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csasarak
changed the title
spatten
approved these changes
May 9, 2024
Changelog.md
Outdated
| @@ -1,5 +1,8 @@ | |||
| # FOSSA CLI Changelog | |||
|
|
|||
| ## Unreleased | |||
| - Release a Mac arm64 binary. | |||
There was a problem hiding this comment.
[nit] We should include a link to the PR
Suggested change
| - Release a Mac arm64 binary. | |
| - Release a Mac arm64 binary ([#1426](https://github.com/fossas/fossa-cli/pull/1426). |
There was a problem hiding this comment.
Also, do you want to just change ## Unreleased to ## v3.9.19 so that we don't need a separate PR to prep for release?
| @@ -28,7 +28,7 @@ jobs: | |||
| ghc: '9.4.8' | |||
|
|
|||
| - os: macos-12 | |||
There was a problem hiding this comment.
Let's add a comment that macos-12 was the last version of the macos runner that uses intel
|
Did you test that themis works from it? It did in my testing but it's good to get another check. @spatten I'll incorporate your suggestions. |
I hadn't, but I just did and it works. Good call! results in output from Themis |
csasarak
added a commit
that referenced
this pull request
May 11, 2024
csasarak
added a commit
that referenced
this pull request
May 13, 2024
csasarak
added a commit
that referenced
this pull request
May 28, 2024
* Reapply "Add Mac arm64 executable (#1426)" (#1429) This reverts commit 36e62bb. * Zip up the right archive. * Try adding an entitlement. * Explicitly install xz. * try entitlements. * Move entitlements arg. * Fix condition * wip * Only use entitlements for arm64. * Use correct equality. * Restore full conditional. * Fix conditional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds an arm build of the CLI for Mac. You can get binaries from the
build macOS-aarch64-buildaction below.I will relax and replace some of the required checks for this branch before and after the merge to master.
Acceptance criteria
A build that works on Mac M1.
Testing plan
I set up an ARM EC2 instance, copied the binaries there and ran them. Additionally I ran a direct license-scan to verify that the license scan program worked correctly.
If you are on an ARM mac, downloading the binaries from the release step and running them should also test this.
I tested the install script to make sure that it correctly selects the arm build if it's fetching a valid version. Otherwise it falls back to the intel version of the CLI like before.
Currently, running the cli and just getting the latest fails with a 404, but the generated URL is what I expect it to be:
Risks
Costs will increase since we will be allocating two runners for Mac per build. Caching may become less reliable as we make more cache data as well.
Metrics
References
ANE-572
Checklist
docs/.docs/README.msand gave consideration to how discoverable or not my documentation is.Changelog.md. If this PR did not mark a release, I added my changes into an# Unreleasedsection at the top..fossa.ymlorfossa-deps.{json.yml}, I updateddocs/references/files/*.schema.jsonAND I have updated example files used byfossa initcommand. You may also need to update these if you have added/removed new dependency type (e.g.pip) or analysis target type (e.g.poetry).docs/references/subcommands/<subcommand>.md.