-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Treat issue summary targets optional #1422
Conversation
src/Fossa/API/Types.hs
Outdated
<$> obj | ||
.: "revision" | ||
<*> obj | ||
.: "targets" | ||
.:? "targets" | ||
.!= [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Optional] I think older versions may not, but the newer CI/Fourmolu/HLS 2.7.0.0 should accept:
<$> obj .: "revision"
<*> obj .:? "targets" .!= []
Which I think is nicer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
omg thank you, added a commit that fixes this across the codebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even better than Christmas!
Overview
Companion PR to https://github.com/fossas/FOSSA/pull/12559, fixes https://fossa.atlassian.net/browse/ANE-1738 but in a different way.
Updates the issue summary datatype to treat targets as optional.
Note: I put this in "unreleased" because, since we're also doing the Core-side change, I don't think this is worth the time of going through the release process on its own, and can just go in the next release we perform.
Mostly I just integrated this change on this end for on-premise users and for completeness (if we consider it optional, we should consider it optional on the client side too).
Acceptance criteria
fossa test
andfossa report
are able to work on first-party-license-scanned builds, without the changes in the linked Core PR.Testing plan
I tested manually against the current production version of FOSSA:
After this change:
Risks
None
Metrics
None
References
Fixes https://fossa.atlassian.net/browse/ANE-1738
Checklist
docs/
.docs/README.ms
and gave consideration to how discoverable or not my documentation is.Changelog.md
. If this PR did not mark a release, I added my changes into an# Unreleased
section at the top..fossa.yml
orfossa-deps.{json.yml}
, I updateddocs/references/files/*.schema.json
AND I have updated example files used byfossa init
command. You may also need to update these if you have added/removed new dependency type (e.g.pip
) or analysis target type (e.g.poetry
).docs/references/subcommands/<subcommand>.md
.