Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Broker debug bundles are now able to persist across mount points.
Similar fix to #80, I just didn't think to persist this fix here. I've checked for other uses of
persist
orrename
in the codebase and found none.Acceptance criteria
Users on systems where the temp file location is on a different mount point can now generate debug bundles.
Testing plan
This unfortunately isn't really testable in automated testing, but I did test it on my Arch system:
Risks
No real risk; this temporarily causes the hard disk to require 2x debug bundle size but that shouldn't be an issue for any of our users.
References
https://teamfossa.slack.com/archives/C04UBSBT822/p1685637742066709?thread_ts=1685637725.732069&cid=C04UBSBT822
Checklist