Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle creation #93

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Fix bundle creation #93

merged 2 commits into from
Jun 12, 2023

Conversation

jssblck
Copy link
Member

@jssblck jssblck commented Jun 12, 2023

Overview

Broker debug bundles are now able to persist across mount points.
Similar fix to #80, I just didn't think to persist this fix here. I've checked for other uses of persist or rename in the codebase and found none.

Acceptance criteria

Users on systems where the temp file location is on a different mount point can now generate debug bundles.

Testing plan

This unfortunately isn't really testable in automated testing, but I did test it on my Arch system:

jess in 🌐 grace in broker on  fix-bundle-creation [!] is 📦 v0.2.2 via 🦀 v1.69.0 took 3s
❯ cargo run -- fix --export-bundle
   Compiling broker v0.2.2 (/home/jess/projects/broker)
    Finished dev [unoptimized + debuginfo] target(s) in 3.22s
     Running `target/debug/broker fix --export-bundle`
2023-06-12T19:22:09.442973Z Debug artifacts being stored in '/home/jess/.config/fossa/broker/debugging/trace'

Diagnosing connections to configured repositories

✅ https://github.com/replit/upm.git

Diagnosing connection to FOSSA

✅ check fossa API connection with no auth required
✅ check fossa API connection with auth required

Collecting debug bundle

✅ Collected debug bundle at 'fossa.broker.debug.tar.gz'
Please include this debug bundle in any request to FOSSA Support.

jess in 🌐 grace in broker on  fix-bundle-creation [!?] is 📦 v0.2.2 via 🦀 v1.69.0
❯ ll | grep debug
.rw------- 1.2M 12 Jun 12:22 -I fossa.broker.debug.tar.gz

Risks

No real risk; this temporarily causes the hard disk to require 2x debug bundle size but that shouldn't be an issue for any of our users.

References

https://teamfossa.slack.com/archives/C04UBSBT822/p1685637742066709?thread_ts=1685637725.732069&cid=C04UBSBT822

Checklist

  • I added tests for this PR's change (or explained in the PR description why tests don't make sense).

@jssblck jssblck requested a review from a team as a code owner June 12, 2023 19:28
@jssblck jssblck requested review from zlav and spatten June 12, 2023 19:28
Copy link
Contributor

@spatten spatten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@jssblck jssblck merged commit 4cd9094 into main Jun 12, 2023
@jssblck jssblck deleted the fix-bundle-creation branch June 12, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants