phpExtensions.mssql: fix build on darwin #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drupol
force-pushed
the
php/extension/update-mssql-for-darwin-and-php56
branch
5 times, most recently
from
0e66753 to
11e2ca1
Compare
drupol
changed the title
drupol
changed the title
|
I may have a better patch... working on it. |
drupol
force-pushed
the
php/extension/update-mssql-for-darwin-and-php56
branch
3 times, most recently
from
fc2c766 to
a7e6518
Compare
|
Patch updated using |
drupol
force-pushed
the
php/extension/update-mssql-for-darwin-and-php56
branch
from
a7e6518 to
b978168
Compare
drupol
force-pushed
the
php/extension/update-mssql-for-darwin-and-php56
branch
from
b978168 to
bff5d9a
Compare
drupol
changed the title
jtojnar
approved these changes
Jul 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mssql extension should work on Darwin, see https://github.com/macports/macports-ports/blob/4187b946818f36f17a78e126780ff901be1e5d0e/lang/php/Portfile#L1408
The build now works on Darwin: https://github.com/fossar/nix-phps/actions/runs/5567766813/jobs/10169895943
Patch inspired by https://github.com/macports/macports-ports/blob/4187b946818f36f17a78e126780ff901be1e5d0e/lang/php/files/patch-php52-ext-pdo_oci-config.m4.diff