Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

system: null_device #945

Merged
merged 5 commits into from
Mar 10, 2025
Merged

system: null_device #945

merged 5 commits into from
Mar 10, 2025

Conversation

perazz
Copy link
Member

@perazz perazz commented Mar 7, 2025

Standardize the null_device function (previously in the subprocess submodule).

This PR aims to provide a standard cross-platform reference to the null device file name.

  • uses a macro-based C static interface for zero overhead
  • Add test and examples

cc: @jvdp1 @jalvesz

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @perazz

@perazz
Copy link
Member Author

perazz commented Mar 9, 2025

Thank you @jvdp1! Let us wait another day or two for comments. Then, I think we can merge this simple PR.

Copy link
Contributor

@jalvesz jalvesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @perazz, thanks for this PR!

@perazz
Copy link
Member Author

perazz commented Mar 10, 2025

Thank you @jvdp1 @jalvesz, I will merge this PR.

@perazz perazz merged commit 954a84b into fortran-lang:master Mar 10, 2025
14 checks passed
@perazz perazz deleted the os_null_device branch March 10, 2025 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants