Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #744 (previous fix: #736)
The following line is causing a segfault on macOS, gfortran 13.2.0, hence failed test:
stdlib/test/string/test_string_intrinsic.f90
Line 717 in b8fbb3c
I believe this line is invalid Fortran because it violates the no-alising rule: two dummy arguments passed by reference cannot point to the same address. So probably, gfortran optimizes out the temporary variable which then causes trouble.
My proposed solution is to check the address first, and avoid the dangerous operation if the variable is the same.
cc: @Pranavchiku @wpbonelli @jvdp1 @awvwgk