-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implemented low-level replace_all function #436
Conversation
Although I have added |
This comment is regarding commit e325c2b. Please note that for input: If we would have designed Both these replacements are happening in the one single call of Moreover, this behaviour cannot be achieved by running @arjenmarkus too has highlighted a similar behaviour through this sentence in his comment:
Whole aim of the comment was to highlight the problems with subroutine kind of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
On page 124 of https://j3-fortran.org/doc/year/18/18-007r1.pdf, It is mentioned that output of character slicing is of length |
@fortran-lang/push-access Can anyone help out with reviewing this patch to allow @aman-godara to move forward with his GSoC project? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @aman-godara, I think this is a very nice addition.
I can't find the explanation in this thread or in the related issue: Why did you choose pure
over elemental
?
All good, I see why, please disregard 👍 |
Let me still mention it for future reference, for example:
|
#366
Current implement provides with
replace_overlapping
optional dummy argument which islogical
.This argument helps provide functionality of both OPTION: 1 and OPTION: 2 of overlapping problem depending upon whether it is set to
.true.
or.false.
.[EDIT]:
replace_overlapping
has been removed fromreplace_all
now.Tasks:
replace_all
functionreplace_all
to show the behaviour of the functionreplace_all