CI(gha): test w/ multiple GFortrans & macOS too #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbeekman
force-pushed
the
CI
branch
3 times, most recently
from
77105ed
to
c000257
Compare
|
@certik This should be ready for review |
|
I'd like to rebase on the latest commits, and switch to out of source build. But I can do the latter in a separate PR I guess. |
|
This looks great! Thank you. Yes, if you could rebase on top of the latest master, just in case. Then in separate PR after this is merged, we can get it working in out of tree builds. |
|
Fantastic! Good to merge IMO. |
|
@certik @milancurcic rebased on latest master |
|
It's in! Thanks a lot @zbeekman, this is super helpful. Now we just need to get Windows covered, and we'll be in good shape. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #30
Test GFortran 7,8 & 9 on macOS and Linux
Also, install newer CMake on CI using pip.