Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dutch translation #119

Merged
merged 1 commit into from
May 5, 2024
Merged

Add Dutch translation #119

merged 1 commit into from
May 5, 2024

Conversation

GewoonLeonYT
Copy link
Contributor

I'm unsure of the correct interpretation of credits.library, therefore I left a comment there and am submitting this as a draft PR.

@vgmoose
Copy link
Member

vgmoose commented Apr 26, 2024

Thank you very much! I've been meaning to add some info about contributing translations to the readme, but happy that you've already gone for it.

For that line, I did intend support in general, although the ambiguity in English isn't necessarily a bad interpretation either.

As an aside, those credits strings are currently still hardcoded into hb-appstore, but I intend to move them (and the localization of them) into the meta-repo in the future. But, it'd need to be translated either way. We also need to add a section for translator credits. 🙏

@GewoonLeonYT
Copy link
Contributor Author

I've changed the translation and removed the comment. It should be ready now.

@GewoonLeonYT GewoonLeonYT marked this pull request as ready for review May 5, 2024 07:56
@vgmoose vgmoose merged commit ae993c0 into fortheusers:main May 5, 2024
6 checks passed
@vgmoose
Copy link
Member

vgmoose commented May 5, 2024

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants