Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightning loop #209

Merged
merged 4 commits into from
Jul 28, 2020
Merged

Lightning loop #209

merged 4 commits into from
Jul 28, 2020

Conversation

nixbitcoin
Copy link
Member

This PR integrates lightning-loop in nix-bitcoin. Lightning Loop is a Non-Custodial Off/On Chain Bridge. It can be used for improvised CoinSwaps that utilize the privacy properties of LN.

Details

Tested with a succesful loop out tx f8178663a03d5b492d756f43b9989c1e7f42640b0c837d4957f29080d025d3bd

@nixbitcoin nixbitcoin force-pushed the lightning-loop branch 3 times, most recently from 6c4c7c4 to 17cd183 Compare July 19, 2020 13:19
@nixbitcoin
Copy link
Member Author

Rebased with upstream lnd

@nixbitcoin nixbitcoin force-pushed the lightning-loop branch 3 times, most recently from 82f2629 to 96b36a9 Compare July 26, 2020 11:33
@sputn1ck
Copy link
Contributor

I have not looked at the code, but tested a loop in and loop out in my krops setup and it worked great!

@nixbitcoin
Copy link
Member Author

Thank you for the blind trust!

@nixbitcoin
Copy link
Member Author

Check that lightning-loop fails with the right error, making sure lightning-loop can connect to lnd

Copy link
Member

@jonasnick jonasnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK e920494

@jonasnick jonasnick merged commit 0baeb2a into fort-nix:master Jul 28, 2020
@Kixunil
Copy link

Kixunil commented Jul 28, 2020

Today I attempted to integrate loop into my deb repository and found out it doesn't support authentication yet How did you secure it? Do you rely on namespaces only?

@nixbitcoin
Copy link
Member Author

nixbitcoin commented Jul 29, 2020

Yes, lightning-loop relies on running inside its own network namespace for security. Only users inside the nb-lightning-loop namespace can reach the loopd daemon, and only the semi-privileged operator user can place processes into that namespace. Ideally we would get defense-in-depth with authentication. Thank you for linking the issue, we will update lightning-loop as soon as the issue is closed.

@sputn1ck sputn1ck mentioned this pull request Aug 5, 2020
@nixbitcoin nixbitcoin deleted the lightning-loop branch March 3, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants