Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --dry-run option to push-release script #206

Merged
merged 1 commit into from
Sep 22, 2020
Merged

Add --dry-run option to push-release script #206

merged 1 commit into from
Sep 22, 2020

Conversation

jonasnick
Copy link
Member

This helped testing #205

@jonasnick
Copy link
Member Author

This has some issues. Marking as WIP

@jonasnick jonasnick changed the title Add --dry-run option to push-release script WIP: Add --dry-run option to push-release script Aug 4, 2020
@jonasnick jonasnick changed the title WIP: Add --dry-run option to push-release script Add --dry-run option to push-release script Aug 16, 2020
@jonasnick
Copy link
Member Author

Issues should be fixed now

@erikarvstedt
Copy link
Collaborator

Here are some fixes.

@jonasnick
Copy link
Member Author

@erikarvstedt thanks! Squashed your fixes into my branch.

erikarvstedt
erikarvstedt approved these changes Aug 18, 2020
View reviewed changes
Copy link
Collaborator

@erikarvstedt erikarvstedt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK dd78d2b

jonasnick added a commit to jonasnick/nix-bitcoin that referenced this pull request Aug 20, 2020
@jonasnick
Merge fort-nix#206: Add --dry-run option to push-release script
95342c0 
dd78d2b Add --dry-run option to push-release script (Jonas Nick)

Pull request description:

ACKs for top commit:
  erikarvstedt:
    ACK dd78d2b

Tree-SHA512: 1ff4d1d69ad581dc71f6f715d2811e73656b20d876777ba1e4c2b6c7d5e26567aba70124d73279ee4eb1210888e365f8e3236c6f7dfced45c5b912ed3308c96e
@erikarvstedt erikarvstedt mentioned this pull request Aug 20, 2020
Merged
nixbitcoin
nixbitcoin approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@nixbitcoin nixbitcoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK dd78d2b

@jonasnick jonasnick merged commit 6554e69 into fort-nix:master Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikarvstedt erikarvstedt erikarvstedt approved these changes

@nixbitcoin nixbitcoin nixbitcoin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonasnick @erikarvstedt @nixbitcoin