-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BTCPayServer package #179
Conversation
c523b65
to
c2187ca
Compare
pkgs/btcpayserver/dotnet-build.nix
Outdated
, config ? "Release" | ||
, target ? "linux-x64", ... }: | ||
let | ||
nuget-pkg-json = if nugetPackages == null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace
pkgs/btcpayserver/dotnet-build.nix
Outdated
, target ? "linux-x64", ... }: | ||
let | ||
nuget-pkg-json = if nugetPackages == null | ||
then lib.importJSON (lesrc + "/${path}${project}/nuget-packages.json") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace
Making this into a module should be as easy as running both nbxplorer and btcpayserver with systemd and letting the user configure with the web-interface. We should also provide an easy option to switch between a Tor-only deployment and a clearnet-allowed deployment. In the case of clearnet deployments all outgoing connections like price-queries should still be forwarded over the Tor proxy. |
ver=${rev:1} | ||
fi | ||
|
||
sha256=$(nix-prefetch-github "$owner" "$repo" --rev "$rev" | jq -r .sha256) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about using fetchurl and calculating the sha256 with git archive
from Nicolas Dorier's signed git commits (0x6618763EF09186FE)? Similar to pkgs/electrs/default.nix
and pkgs/electrs/get-sha256.sh
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah this would be easy to do, I think I had this for testing git revisions. We should just be doing nix-prefetch-url with signed tarballs instead
@nixbitcoin feel free to take inspiration from my project. I have onion-by-default, clearnet-optional implemented already. It can handle other apps (like RTL) too. However, it's still not a privacy feature (just to get a domain and bypass NAT). Accesses are not torified yet. |
I noticed this as well, I don't remember it being like this before, it's possible I introduced some non-deterministic parallelism in dotnet2nix somehow. I'll try to see what's up. |
This is needed for BTCPayServer and NBXplorer Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Signed-off-by: William Casarin <jb55@jb55.com>
Just stable for now, unstable isn't working Signed-off-by: William Casarin <jb55@jb55.com>
Superseded by NixOS/nixpkgs#95104 |
This is a simplified version of #88, with an update script this time!
module to come in a future PR