Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corner size not applied #38

Closed
javadghane opened this issue Aug 21, 2020 · 4 comments · Fixed by #45
Closed

Corner size not applied #38

javadghane opened this issue Aug 21, 2020 · 4 comments · Fixed by #45
Labels
enhancement New feature or request Major It means priority is high

Comments

@javadghane
Copy link

Version used: 0.2.0
Devices/Android versions reproduced on: Galaxy note 4

  • Sample codes to trigger the issue.
  <soup.neumorphism.NeumorphCardView
            android:layout_width="150dp"
            android:layout_height="150dp"
            app:neumorph_backgroundColor="@color/backColor"
            app:neumorph_inset="12dp"
            app:neumorph_shadowColorDark="@color/neu_card_dark"
            app:neumorph_shadowColorLight="@color/neu_card_lighter"
            app:neumorph_shadowElevation="4dp"
            app:neumorph_shapeAppearance="@style/RectangleNeuCardViewForHomePage">

            <ImageView
                android:layout_width="match_parent"
                android:layout_height="match_parent"
                android:layout_margin="4dp"
                app:srcCompat="@drawable/ic_stage" />

        </soup.neumorphism.NeumorphCardView>

style:

 <style name="RectangleNeuCardViewForHomePage">
        <item name="cornerSizeBottomLeft">12dp</item>
        <item name="cornerSizeBottomRight">12dp</item>
        <item name="cornerSizeTopLeft">360dp</item>
        <item name="cornerSizeTopRight">360dp</item>
    </style>
  • A screenrecord or screenshots showing the issue.

i want to create this shape type (top corner different from bottom)
topRounded

but corner size not applied.
result

@javadghane javadghane added the bug Something isn't working label Aug 21, 2020
@tamimattafi
Copy link

tamimattafi commented Aug 30, 2020

You cannot specify each corner's radius separately, such attributes do not exist in this library.
What you can do is to define a general radius using neumorph_cornerSize attribute followed by neumorph_cornerFamily which should equal to rounded if you want to be able to control radius.

@javadghane
Copy link
Author

Thanks @tamimattafi.
@fornewid it is possible to add this feature to next version library?

@fornewid
Copy link
Owner

fornewid commented Sep 3, 2020

@javadghane 🙆‍♂️ I'll consider to add options for each corner size in the next release.

@fornewid fornewid added Major It means priority is high enhancement New feature or request and removed bug Something isn't working labels Sep 3, 2020
fornewid added a commit that referenced this issue Sep 25, 2020
Library: Supports different radii depending on the corner (#38)
@ZarSaeed
Copy link

even "neumorph_cornerSize" not working for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Major It means priority is high
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants