FIO-7615: Add option to migrate pdf files to copy and migrate commands #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanbond
requested changes
Feb 19, 2025
src/copy.js
Outdated
| return cb(); | ||
| }; | ||
|
|
||
| // For each source form, copy the components after uniquifying them. | ||
| async.eachSeries(sourceForms, function(src, cb) { | ||
| fetch(options)({ | ||
| url: src | ||
| }).then(({body: form}) => { | ||
| copyComponents(form, cb); | ||
| }).then(async({body: form}) => { |
There was a problem hiding this comment.
This is a minor issue but I don't love mixing modalities here - can we either use all async/await or stick with promise chaining here? I think if it were me I'd stick with promise chaining, because refactoring this file (and potentially others) to async/await would be a lot of work, whereas it's relatively clean and easy to use promise chaining here
brendanbond
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://formio.atlassian.net/browse/FIO-7615