Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save statement implementation #17

Merged
merged 7 commits into from
Nov 8, 2024
Merged

Conversation

ascandone
Copy link
Contributor

@ascandone ascandone commented Nov 8, 2024

TODOs:

  • parse "save" syntax
  • handle statement in interpreter
  • handle statement in static analysis

@ascandone ascandone changed the title Feat/implement save functionality Save statement implementation Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 88.57868% with 45 lines in your changes missing coverage. Please review.

Project coverage is 63.09%. Comparing base (db8980f) to head (d68e701).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/parser/antlr/numscript_parser.go 86.48% 18 Missing and 2 partials ⚠️
internal/interpreter/interpreter.go 75.00% 9 Missing and 3 partials ⚠️
internal/interpreter/batch_balances_query.go 64.70% 4 Missing and 2 partials ⚠️
internal/analysis/hover.go 77.77% 3 Missing and 1 partial ⚠️
internal/parser/antlr/numscript_base_listener.go 0.00% 2 Missing ⚠️
internal/parser/ast.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #17      +/-   ##
==========================================
+ Coverage   62.83%   63.09%   +0.26%     
==========================================
  Files          28       28              
  Lines        6024     6176     +152     
==========================================
+ Hits         3785     3897     +112     
- Misses       2079     2112      +33     
- Partials      160      167       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ascandone ascandone requested a review from altitude November 8, 2024 15:00
@ascandone ascandone requested a review from gfyrag November 8, 2024 15:18
@ascandone
Copy link
Contributor Author

Adding @altitude and @gfyrag as reviewers because, even though the PR is in still draft, the next part of the PR won't change the currently commited code

@ascandone ascandone force-pushed the feat/implement-save-functionality branch from ea512a1 to e8d5f70 Compare November 8, 2024 17:20
@ascandone ascandone marked this pull request as ready for review November 8, 2024 17:22
@ascandone ascandone requested a review from gfyrag November 8, 2024 17:39
@ascandone ascandone merged commit 4293e52 into main Nov 8, 2024
5 checks passed
@ascandone ascandone deleted the feat/implement-save-functionality branch November 8, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants