better panic description

analysis/diagnostic_kind.go

@@ -3,6 +3,7 @@ package analysis
 import (
 	"fmt"
 	"math/big"
+	"numscript/utils"
 )
 
 type Severity = byte
@@ -17,21 +18,6 @@ const (
 	Hint
 )
 
-func SeverityToString(s Severity) string {
-	switch s {
-	case ErrorSeverity:
-		return "Error"
-	case WarningSeverity:
-		return "Warning"
-	case Information:
-		return "Info"
-	case Hint:
-		return "Hint"
-	default:
-		panic("Invalid error type")
-	}
-}
-
 func SeverityToAnsiString(s Severity) string {
 	switch s {
 	case ErrorSeverity:
@@ -43,7 +29,7 @@ func SeverityToAnsiString(s Severity) string {
 	case Hint:
 		return "Hint"
 	default:
-		panic("Invalid error type")
+		return utils.NonExhaustiveMatchPanic[string](s)
 	}
 }
 
@@ -163,7 +149,7 @@ func (e *BadAllotmentSum) Message() string {
 		return fmt.Sprintf("Allotment portions are lesser than one (Got %s). Maybe try adding a 'remaining' clause?", e.Sum.String())
 	}
 
-	panic("Invalid diagnostic")
+	panic(fmt.Sprintf("unreachable state: allotment=%s", e.Sum.String()))
 }
 func (*BadAllotmentSum) Severity() Severity {
 	return ErrorSeverity

analysis/hover.go

@@ -2,6 +2,7 @@ package analysis
 
 import (
 	"numscript/parser"
+	"numscript/utils"
 )
 
 type Hover interface{ hover() }
@@ -84,7 +85,7 @@ func hoverOnSentValue(sentValue parser.SentValue, position parser.Position) Hove
 		return hoverOnLiteral(sentValue.Monetary, position)
 
 	default:
-		panic("Unhandled clause")
+		return utils.NonExhaustiveMatchPanic[Hover](sentValue)
 	}
 }
 
@@ -222,7 +223,7 @@ func hoverOnKeptOrDestination(inorderClause parser.KeptOrDestination, position p
 		return hoverOnDestination(inorderClause.Destination, position)
 
 	default:
-		panic("Unhandled clause")
+		return utils.NonExhaustiveMatchPanic[Hover](inorderClause)
 	}
 
 }

lsp/handlers.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"numscript/analysis"
 	"numscript/parser"
+	"numscript/utils"
 
 	"github.com/sourcegraph/jsonrpc2"
 )
@@ -102,7 +103,7 @@ func (state *State) handleHover(params HoverParams) *Hover {
 
 			msg = fmt.Sprintf("`%s%s -> %s`\n\n%s", hoverable.Node.Caller.Name, params, resolved.Return, resolved.Docs)
 		default:
-			panic("Unhandled clause")
+			utils.NonExhaustiveMatchPanic[any](resolved)
 		}
 
 		return &Hover{

parser/parser.go

@@ -3,6 +3,7 @@ package parser
 import (
 	"math"
 	parser "numscript/parser/antlr"
+	"numscript/utils"
 	"strconv"
 	"strings"
 
@@ -146,7 +147,7 @@ func parseCapLit(capCtx parser.ICapContext) Literal {
 		return nil
 
 	default:
-		panic("Invalid ctx")
+		return utils.NonExhaustiveMatchPanic[Literal](capCtx.GetText())
 	}
 }
 
@@ -215,7 +216,7 @@ func parseSource(sourceCtx parser.ISourceContext) Source {
 		return nil
 
 	default:
-		panic("unhandled context: " + sourceCtx.GetText())
+		return utils.NonExhaustiveMatchPanic[Source](sourceCtx.GetText())
 	}
 }
 
@@ -231,7 +232,7 @@ func parseVariableAccount(variableAccountCtx parser.IVariableAccountContext) Lit
 		return nil
 
 	default:
-		panic("Unhandled clause")
+		return utils.NonExhaustiveMatchPanic[Literal](variableAccountCtx.GetText())
 	}
 
 }
@@ -297,7 +298,7 @@ func parseAllotment(allotmentCtx parser.IAllotmentContext) SourceAllotmentValue
 		return nil
 
 	default:
-		panic("Invalid allotment")
+		return utils.NonExhaustiveMatchPanic[SourceAllotmentValue](allotmentCtx.GetText())
 	}
 }
 
@@ -341,7 +342,7 @@ func parseLiteral(literalCtx parser.ILiteralContext) Literal {
 		return nil
 
 	default:
-		panic("unhandled clause")
+		return utils.NonExhaustiveMatchPanic[Literal](literalCtx.GetText())
 	}
 }
 
@@ -377,7 +378,7 @@ func parsePortionSource(portionCtx parser.IPortionContext) *RatioLiteral {
 		return nil
 
 	default:
-		panic("unhandled portion ctx")
+		return utils.NonExhaustiveMatchPanic[*RatioLiteral](portionCtx.GetText())
 	}
 }
 
@@ -426,8 +427,7 @@ func parseDestination(destCtx parser.IDestinationContext) Destination {
 		return nil
 
 	default:
-		panic("Unhandled dest" + destCtx.GetText())
-
+		return utils.NonExhaustiveMatchPanic[Destination](destCtx.GetText())
 	}
 
 }
@@ -458,7 +458,7 @@ func parseKeptOrDestination(clauseCtx parser.IKeptOrDestinationContext) KeptOrDe
 		return nil
 
 	default:
-		panic("Unhandled clause")
+		return utils.NonExhaustiveMatchPanic[KeptOrDestination](clauseCtx.GetText())
 	}
 
 }
@@ -480,7 +480,7 @@ func parseDestinationAllotment(allotmentCtx parser.IAllotmentContext) Destinatio
 		return nil
 
 	default:
-		panic("unhandled portion ctx")
+		return utils.NonExhaustiveMatchPanic[DestinationAllotmentValue](allotmentCtx.GetText())
 	}
 }
 
@@ -496,7 +496,7 @@ func parseDestinationPortion(portionCtx parser.IPortionContext) DestinationAllot
 		return nil
 
 	default:
-		panic("unhandled portion ctx")
+		return utils.NonExhaustiveMatchPanic[DestinationAllotmentValue](portionCtx.GetText())
 	}
 }
 
@@ -547,7 +547,7 @@ func parseStatement(statementCtx parser.IStatementContext) Statement {
 		return nil
 
 	default:
-		panic("unhandled clause")
+		return utils.NonExhaustiveMatchPanic[Statement](statementCtx.GetText())
 	}
 }
 
@@ -567,7 +567,7 @@ func parseSentValue(statementCtx parser.ISentValueContext) SentValue {
 		return nil
 
 	default:
-		panic("Unhandled clause")
+		return utils.NonExhaustiveMatchPanic[SentValue](statementCtx.GetText())
 	}
 
 }
@@ -593,7 +593,7 @@ func parseVariableMonetary(sendExpr parser.IVariableMonetaryContext) Literal {
 		return nil
 
 	default:
-		panic("Unhandled clause")
+		return utils.NonExhaustiveMatchPanic[Literal](sendExpr.GetText())
 	}
 }
 
@@ -602,7 +602,7 @@ func parseNumberLiteral(numNode antlr.TerminalNode) *NumberLiteral {
 
 	amt, err := strconv.Atoi(amtStr)
 	if err != nil {
-		panic("Invalid amt: " + amtStr)
+		panic("Invalid number: " + amtStr)
 	}
 
 	return &NumberLiteral{
@@ -623,7 +623,7 @@ func parseVariableNumber(numCtx parser.IVariableNumberContext) Literal {
 		return nil
 
 	default:
-		panic("Unhandled clause")
+		return utils.NonExhaustiveMatchPanic[Literal](numCtx.GetText())
 	}
 }
 
@@ -642,7 +642,7 @@ func parseVariableAsset(assetCtx parser.IVariableAssetContext) Literal {
 		return nil
 
 	default:
-		panic("Unhandled clause")
+		return utils.NonExhaustiveMatchPanic[Literal](assetCtx.GetText())
 	}
 }
 

utils/utils.go

@@ -0,0 +1,7 @@
+package utils
+
+import "fmt"
+
+func NonExhaustiveMatchPanic[T any](value any) T {
+	panic(fmt.Sprintf("Non exhaustive match (got '%#v')", value))
+}