Remove unnecessary comments #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filipeom
force-pushed
the
reduce-global-vars
branch
from
51cb845 to
57a6f5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary comments.
Currently the most used (by code references) global variables are
|Intrinsics|,|global|, and|realm|. I think only having these three is acceptable. Although we could probably reduce this even further and only use|realm|since it has pointers to the same objects|Intrinsics|and|global|point to. But I think this is good enough to close #219.Then we also have a couple implementation global variables to maintain the state of the interpreter, but these we cannot get rid of. Some of them are:
|ElementTable||ctxStack||ScriptJobQueue||PromiseJobQueue|