Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: append forward slash to folder types manifest entries #1407

Merged
merged 8 commits into from
Sep 9, 2024

Conversation

shetzel
Copy link
Contributor

@shetzel shetzel commented Aug 29, 2024

What does this PR do?

InFolder types are different (e.g., Report/ReportFolder). ReportFolders are deployed/retrieved as Reports. If a ReportFolder is being added, append a "/" so the metadata API can identify it as a folder.

What issues does this PR fix or reference?

@W-16618232@

@shetzel shetzel requested a review from a team as a code owner August 29, 2024 21:46
@WillieRuemmele
Copy link
Member

QA Notes


✅ : able to retrieve nested report folders without trailing /
✅ : current workaround continues to work
✅ : retrieves same MD
✅ : DashboardFolders/source tracking works

 ➜  ../../oss/plugin-deploy-retrieve/bin/run.js project retrieve start
Retrieving v60.0 metadata from test-asbczi4doj4f@example.com using the v61.0 SOAP API
Preparing retrieve request... Succeeded

Retrieved Source
==========================================================================================================
| State   Name       Type            Path                                                                  
| ─────── ────────── ─────────────── ───────────────────────────────────────────────────────────────────── 
| Created top/su/su1 DashboardFolder force-app/main/default/dashboards/top/su/su1.dashboardFolder-meta.xml 

@WillieRuemmele WillieRuemmele merged commit 4d35ce3 into main Sep 9, 2024
74 checks passed
@WillieRuemmele WillieRuemmele deleted the sh/support-folder-types-better branch September 9, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants