W-16273581 fix: manifests for custom object can omit parent #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
changed the title
mshanemc
commented
Jul 25, 2024
| ? fullName.split('.')[1] | ||
| : fullName | ||
| ); | ||
| const type = this.registry.getTypeByName(typeId); | ||
|
|
||
| // Add children |
There was a problem hiding this comment.
the children are always added. the parent might or might not be depending on if it has content.
doing the children first lets the parent conditionally return early
mshanemc
commented
Jul 25, 2024
| @@ -750,3 +737,28 @@ const splitOnFirstDelimiter = (input: string): [string, string] => { | |||
| const indexOfSplitChar = input.indexOf(KEY_DELIMITER); | |||
| return [input.substring(0, indexOfSplitChar), input.substring(indexOfSplitChar + 1)]; | |||
| }; | |||
|
|
|||
| /** side effect: mutates the typeMap property */ | |||
| const addToTypeMap = ({ | |||
There was a problem hiding this comment.
this code is simplified and now uses a set instead of an array
mshanemc
commented
Jul 25, 2024
| @@ -199,19 +199,3 @@ const getXmlFromCache = | |||
| } | |||
| return xmlCache.get(key) ?? {}; | |||
| }; | |||
|
|
|||
| /** composed function, exported from module for test */ | |||
| export const unwrapAndOmitNS = | |||
There was a problem hiding this comment.
moved for easier sharing
mshanemc
commented
Jul 25, 2024
| @@ -34,11 +40,9 @@ export const DECOMPOSED_VIRTUAL_FS: VirtualDirectory[] = [ | |||
| name: DECOMPOSED_XML_NAME, | |||
| data: Buffer.from(`<CustomObject xmlns="${XML_NS_URL}"><fullName>customObject__c</fullName></CustomObject>`), | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
I don't think it should be
objects/CustomObject__c/Fields__c.field-meta.xml
mshanemc
commented
Jul 25, 2024
| @@ -51,11 +55,11 @@ export const DECOMPOSED_VIRTUAL_FS: VirtualDirectory[] = [ | |||
| ], | |||
| }, | |||
| { | |||
| dirPath: 'fields', | |||
There was a problem hiding this comment.
this didn't have the relative path, just the last segment
mshanemc
commented
Jul 25, 2024
| @@ -0,0 +1,91 @@ | |||
| /* | |||
There was a problem hiding this comment.
copy of the existing one, but has no "real" content in the CustomObject
mshanemc
commented
Jul 25, 2024
| @@ -370,7 +370,9 @@ describe('SourceComponent', () => { | |||
| ); | |||
|
|
|||
| it('should return child components for a component', () => { | |||
| expect(decomposed.DECOMPOSED_COMPONENT.getChildren()).to.deep.equal([expectedChild, expectedChild2]); | |||
QA NOTESSteps to repro
<?xml version="1.0" encoding="UTF-8"?>
<Package xmlns="http://soap.sforce.com/2006/04/metadata">
<types>
<members>Cat__c.Legs__c</members>
<name>CustomField</name>
</types>
<version>61.0</version>
</Package>
<types>
<members>Cat__c-Cat Layout</members>
<name>Layout</name>
</types>
|
QA UPDATE
|
iowillhoit
approved these changes
Aug 1, 2024
iowillhoit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
deploy -d of an entire folder including a blank CustomObject file causes the Object to be in the manifest.
Case 1: If the Object is in the manifest, the mdapi will validate that the Object metadata contains all the required fields.
Case 2: If the Object is not in the manifest (only one or more of its child types are) then the validation doesn't happen (only the child types are validated)
SDR, when generating the manifest, needs to ask if the top-level (ex: object.meta.xml) is effectively empty. If so, that type should be omitted from the manifest (to get Case 2 behavior from the API)
other changes
update some tests that were based on an invalid mock
update the workflow preset to make all children of workflow unaddressable
What issues does this PR fix or reference?
@W-16273581@ (see inv)