chore: check strategy instead

forcedotcom · Feb 7, 2025 · 9c15136 · 9c15136 · svc-cli-bot · Feb 7, 2025
1 parent bd67cf8
commit 9c15136
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/convert/metadataConverter.ts b/src/convert/metadataConverter.ts
@@ -179,7 +179,7 @@ function getMergeConfigOutputs(
   const defaultDirectory = output.defaultDirectory;
   const mergeSet = new ComponentSet(undefined, registry);
   for (const component of output.mergeWith) {
-    if (component.type.id === 'digitalexperience' && !component.parent?.content) {
+    if (component.type.strategies?.adapter === 'digitalExperience' && !component.parent?.content) {
       // DE is addressable without its parent (DEB)
       mergeSet.add(component);
     } else {

diff --git a/src/convert/transformers/defaultMetadataTransformer.ts b/src/convert/transformers/defaultMetadataTransformer.ts
@@ -74,7 +74,7 @@ const getContentSourceDestination = (
   if (mergeWith?.content) {
     if (component.content && component.tree.isDirectory(component.content)) {
       // DEs are always inside a dir.
-      if (component.type.id === 'digitalexperience') {
+      if (component.type.strategies?.adapter === 'digitalExperience') {
         return join(mergeWith.content, basename(source));
       } else {
         const relative = trimUntil(source, basename(component.content));
Benchmark suite	Current: `9c15136`	Previous: `bd67cf8`	Ratio
`eda-componentSetCreate-linux`	`225` ms	`232` ms	`0.97`
`eda-sourceToMdapi-linux`	`2034` ms	`2058` ms	`0.99`
`eda-sourceToZip-linux`	`1872` ms	`1883` ms	`0.99`
`eda-mdapiToSource-linux`	`2627` ms	`2639` ms	`1.00`
`lotsOfClasses-componentSetCreate-linux`	`531` ms	`487` ms	`1.09`
`lotsOfClasses-sourceToMdapi-linux`	`3633` ms	`3635` ms	`1.00`
`lotsOfClasses-sourceToZip-linux`	`2902` ms	`2984` ms	`0.97`
`lotsOfClasses-mdapiToSource-linux`	`3464` ms	`3535` ms	`0.98`
`lotsOfClassesOneDir-componentSetCreate-linux`	`839` ms	`835` ms	`1.00`
`lotsOfClassesOneDir-sourceToMdapi-linux`	`6372` ms	`6332` ms	`1.01`
`lotsOfClassesOneDir-sourceToZip-linux`	`4995` ms	`5161` ms	`0.97`
`lotsOfClassesOneDir-mdapiToSource-linux`	`6235` ms	`6403` ms	`0.97`
Benchmark suite	Current: `9c15136`	Previous: `bd67cf8`	Ratio
`eda-componentSetCreate-win32`	`689` ms	`733` ms	`0.94`
`eda-sourceToMdapi-win32`	`4159` ms	`4230` ms	`0.98`
`eda-sourceToZip-win32`	`3268` ms	`3310` ms	`0.99`
`eda-mdapiToSource-win32`	`6002` ms	`6120` ms	`0.98`
`lotsOfClasses-componentSetCreate-win32`	`1476` ms	`1421` ms	`1.04`
`lotsOfClasses-sourceToMdapi-win32`	`8418` ms	`8499` ms	`0.99`
`lotsOfClasses-sourceToZip-win32`	`5276` ms	`5618` ms	`0.94`
`lotsOfClasses-mdapiToSource-win32`	`8347` ms	`8503` ms	`0.98`
`lotsOfClassesOneDir-componentSetCreate-win32`	`2478` ms	`2634` ms	`0.94`
`lotsOfClassesOneDir-sourceToMdapi-win32`	`14791` ms	`15280` ms	`0.97`
`lotsOfClassesOneDir-sourceToZip-win32`	`9180` ms	`9709` ms	`0.95`
`lotsOfClassesOneDir-mdapiToSource-win32`	`15147` ms	`15004` ms	`1.01`