feat: workspaces support for myDomain checks

forcedotcom · Aug 29, 2024 · 81dcfb3 · 81dcfb3 · svc-cli-bot · Aug 29, 2024
1 parent 56e39c6
commit 81dcfb3
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/src/util/sfdcUrl.ts b/src/util/sfdcUrl.ts
@@ -135,6 +135,7 @@ export class SfdcUrl extends URL {
       '.stm.salesforce.ms',
       '.pc-rnd.force.com',
       '.pc-rnd.salesforce.com',
+      '.wc.crm.dev', // workspaces container
     ];
     return (
       this.origin.startsWith('https://gs1.') ||

diff --git a/test/unit/util/sfdcUrl.test.ts b/test/unit/util/sfdcUrl.test.ts
@@ -179,6 +179,11 @@ describe('util/sfdcUrl', () => {
       expect(url.isInternalUrl()).to.equal(true);
       expect(url.isLocalUrl()).to.equal(true);
     });
+    it('workspaces with port is internal but not local', () => {
+      const url = new SfdcUrl('https://dev.salesforce-com.shane-mclaughlin-0lrfx7zp3l121.wc.crm.dev:6101/');
+      expect(url.isInternalUrl()).to.equal(true);
+      expect(url.isLocalUrl()).to.equal(false);
+    });
   });
 
   describe('checkLightningDomain', () => {
Benchmark suite	Current: `81dcfb3`	Previous: `8b75440`	Ratio
`Child logger creation`	`477992` ops/sec (`±1.49%`)	`474604` ops/sec (`±1.70%`)	`0.99`
`Logging a string on root logger`	`751468` ops/sec (`±7.26%`)	`880537` ops/sec (`±6.85%`)	`1.17`
`Logging an object on root logger`	`599382` ops/sec (`±6.48%`)	`658294` ops/sec (`±4.83%`)	`1.10`
`Logging an object with a message on root logger`	`7685` ops/sec (`±204.38%`)	`22253` ops/sec (`±186.45%`)	`2.90`
`Logging an object with a redacted prop on root logger`	`425314` ops/sec (`±8.19%`)	`505081` ops/sec (`±9.38%`)	`1.19`
`Logging a nested 3-level object on root logger`	`381475` ops/sec (`±7.23%`)	`17569` ops/sec (`±187.34%`)	`0.04605544268956026`
Benchmark suite	Current: `81dcfb3`	Previous: `8b75440`	Ratio
`Child logger creation`	`315377` ops/sec (`±4.09%`)	`328660` ops/sec (`±0.96%`)	`1.04`
`Logging a string on root logger`	`749310` ops/sec (`±6.06%`)	`758669` ops/sec (`±6.01%`)	`1.01`
`Logging an object on root logger`	`590853` ops/sec (`±6.79%`)	`600622` ops/sec (`±7.48%`)	`1.02`
`Logging an object with a message on root logger`	`7073` ops/sec (`±202.35%`)	`7014` ops/sec (`±203.21%`)	`0.99`
`Logging an object with a redacted prop on root logger`	`458132` ops/sec (`±13.24%`)	`497145` ops/sec (`±7.40%`)	`1.09`
`Logging a nested 3-level object on root logger`	`345113` ops/sec (`±4.47%`)	`342448` ops/sec (`±4.22%`)	`0.99`