Madhur/w 17619393 #6017
Merged
Madhur/w 17619393 #6017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peternhale
requested changes
Jan 22, 2025
| @@ -114,6 +120,18 @@ export class ApexActionController { | |||
| telemetryService.sendException(telemetryEvent, errorMessage); | |||
| }; | |||
|
|
|||
| private async validateOpenApiDocument(openapiDocument: string) { | |||
There was a problem hiding this comment.
Suggested change
| private async validateOpenApiDocument(openapiDocument: string) { | |
| private async validateOpenApiDocument(openapiDocument: string): Promise<void> { |
packages/salesforcedx-vscode-apex/src/commands/apexActionController.ts
Outdated
Show resolved
Hide resolved
mingxuanzhangsfdx
requested changes
Jan 23, 2025
package.json
Outdated
| @@ -23,6 +23,9 @@ | |||
| "@octokit/core": "4.2.4", | |||
| "@octokit/webhooks-definitions": "^3.67.3", | |||
| "@salesforce/dev-config": "^3.1.0", | |||
| "@stoplight/spectral-core": "1.19.4", | |||
| "@stoplight/spectral-functions": "1.9.3", | |||
There was a problem hiding this comment.
where are the two dependencies used? @stoplight/spectral-functions and @stoplight/spectral-ruleset-bundler?
There was a problem hiding this comment.
ah my miss, I don't need these any more.
package.json
Outdated
| @@ -23,6 +23,9 @@ | |||
| "@octokit/core": "4.2.4", | |||
| "@octokit/webhooks-definitions": "^3.67.3", | |||
| "@salesforce/dev-config": "^3.1.0", | |||
| "@stoplight/spectral-core": "1.19.4", | |||
There was a problem hiding this comment.
If the dependency is only used in apex, I think we just include it in its package.json. The package.json in root is mostly for the whole monorepo
There was a problem hiding this comment.
I added it in rev2 per Peter's recommendation, to keep pin the dependency to specific version so 1. package size doesn't get bloated 2. no odd behavior.
There was a problem hiding this comment.
Is this file still needed?
There was a problem hiding this comment.
no I thought I have deleted it, will remove it.
madhur310
force-pushed
the
madhur/W-17619393
branch
from
b86cab3 to
b21f2b4
Compare
madhur310
force-pushed
the
madhur/W-17619393
branch
from
b21f2b4 to
03f66f9
Compare
madhur310
changed the base branch from
feat/generation-strategy
to
feat/apex-oas
madhur310
force-pushed
the
madhur/W-17619393
branch
from
6fc9132 to
9bb64f8
Compare
peternhale
approved these changes
Jan 24, 2025
CristiCanizales
added a commit
that referenced
this pull request
Jan 27, 2025
* feat: update jar with changes in lsp to add comments in context (#6025) * feat: update jar with changes in lsp to add comments in context * feat: update jar with changes in lsp to add comments in context * fix: add comment property to context (#6026) @W-17645605@ moved comments from ApexClassOASGatherContextResponse and added comment proeprty to class/method/property * chore: remove deploy and retrieve commands for oas and hide create oas from method command (#6029) * Madhur/w 17619393 (#6017) * feat: adding spectral library and validation based on OAS3 spec * feat: adding spectral library and validation based on OAS3 spec * feat: adding spectral library and validation based on OAS3 spec * feat: adding spectral library and validation based on OAS3 spec * fix: increase minimum supported node version to v20.17.0 * feat: adding spectral library and validation based on OAS3 spec --------- Co-authored-by: Daphne Yang <daphne.yang@salesforce.com> --------- Co-authored-by: Cristina Cañizales <113132642+CristiCanizales@users.noreply.github.com> Co-authored-by: peternhale <peternhale@users.noreply.github.com> Co-authored-by: madhur310 <madhur.shrivastava@salesforce.com> Co-authored-by: Daphne Yang <daphne.yang@salesforce.com>
CristiCanizales
added a commit
that referenced
this pull request
Jan 27, 2025
* Mz/apply generation strategy (#6018) * feat: integrate apex action controller with prompt generation orchestrator * chore: update framework * chore: add error entries * feat: whole class gen strategy (#6024) * feat: integrate apex action controller with prompt generation orchestrator * feat: whole class gen strategy * chore: sort imports * chore: asdfghj --------- Co-authored-by: mingxuanzhang <mingxuanzhang@salesforce.com> * feat: update jar with changes in lsp to add comments in context (#6028) * feat: update jar with changes in lsp to add comments in context (#6025) * feat: update jar with changes in lsp to add comments in context * feat: update jar with changes in lsp to add comments in context * fix: add comment property to context (#6026) @W-17645605@ moved comments from ApexClassOASGatherContextResponse and added comment proeprty to class/method/property --------- Co-authored-by: peternhale <peternhale@users.noreply.github.com> * feat: method-by-method OAS doc generation strategy (#6023) * feat: create open api doc method by method * chore: update for generating ESR * chore: refine * chore: refine prompt structure * feat: enable comments for prompt generation * chore: sync jorje jar * chore: sync generation strategy with latest change (#6031) * feat: update jar with changes in lsp to add comments in context (#6025) * feat: update jar with changes in lsp to add comments in context * feat: update jar with changes in lsp to add comments in context * fix: add comment property to context (#6026) @W-17645605@ moved comments from ApexClassOASGatherContextResponse and added comment proeprty to class/method/property * chore: remove deploy and retrieve commands for oas and hide create oas from method command (#6029) * Madhur/w 17619393 (#6017) * feat: adding spectral library and validation based on OAS3 spec * feat: adding spectral library and validation based on OAS3 spec * feat: adding spectral library and validation based on OAS3 spec * feat: adding spectral library and validation based on OAS3 spec * fix: increase minimum supported node version to v20.17.0 * feat: adding spectral library and validation based on OAS3 spec --------- Co-authored-by: Daphne Yang <daphne.yang@salesforce.com> --------- Co-authored-by: Cristina Cañizales <113132642+CristiCanizales@users.noreply.github.com> Co-authored-by: peternhale <peternhale@users.noreply.github.com> Co-authored-by: madhur310 <madhur.shrivastava@salesforce.com> Co-authored-by: Daphne Yang <daphne.yang@salesforce.com> * chore: remove eslint disable * chore: move schemas to oas folder * chore: sort imports --------- Co-authored-by: Mingxuan Zhang <132491513+mingxuanzhangsfdx@users.noreply.github.com> Co-authored-by: mingxuanzhang <mingxuanzhang@salesforce.com> Co-authored-by: peternhale <peternhale@users.noreply.github.com> Co-authored-by: madhur310 <madhur.shrivastava@salesforce.com> Co-authored-by: Daphne Yang <daphne.yang@salesforce.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: adding spectral library and validation based on OAS3 spec
What does this PR do?
adding spectral library and validation based on OAS3 spec, note currently this just logs the validation errors. We still need a way to display it to user.
What issues does this PR fix or reference?
@W-17619393@
Functionality Before
No OAS specific validation existed.
Functionality After
Validations are happening on OAS docs generated by LLM.