Update Build Infrastructure #225
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #225 +/- ##
===========================================
+ Coverage 81.81% 81.85% +0.04%
===========================================
Files 114 114
Lines 4619 4619
Branches 767 770 +3
===========================================
+ Hits 3779 3781 +2
+ Misses 678 676 -2
Partials 162 162
Continue to review full report at Codecov.
|
|
@vazexqi I wasn't able to get the tests running with the insiders build. It's currently not supported by VS Code. I've opened a feature request to get it added (microsoft/vscode-extension-vscode#88). I'd still like to merge this PR because it contains a few good tweaks to our builds. |
.travis.yml
Outdated
| @@ -15,7 +15,7 @@ notifications: | |||
|
|
|||
| matrix: | |||
| allow_failures: | |||
| - os: osx | |||
| - os: linux | |||
There was a problem hiding this comment.
Can we specify it for both linux and osx? The way you have done it now makes is so that osx must pass, which we know is a losing battle given travis-ci/travis-ci#7304
| @@ -70,5 +70,5 @@ test_script: | |||
|
|
|||
| on_finish: | |||
| - del C:\projects\devhub.key | |||
| - codecov | |||
| - codecov --disable=gcov | |||
There was a problem hiding this comment.
How does this help with long path issues, and why does it only happen now?
There was a problem hiding this comment.
The codecov tool gcov module was scanning very aggressiv for coverage reports. It also scanned the node_modules folders and caused those errors to appear in the build log. Disabling this made those errors go away and our build pass. I wonder if this was the result of a resent update to the codecov tool - we install it at build time via NPM.
|
@guw This looks fine to me. Just a couple of questions. I think we do need to allow osx builds to fail, since they will due to the slow builds. |
This reverts commit 3bbd142.
This reverts commit 9313a18.
With all the tweaks the macOS builds seem to run more reliably then the Linux builds. However, the performance varies because of limites macOS capacity. This is covered in our GitHub setup already by not requiring the Travis build to pass for PRs.
What does this PR do?
Update our Travis CI Build Infra to use Ubuntu Trusty and XCode 9.1 and also reference VS Code 1.19 to work around an bug in 1.18.
What issues does this PR fix or reference?
Fixes the Linux build issues and improved the macOS build.