-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sm/fixes #543
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
QA Complete ✔️ with VS Code - just a few changes!
With Custom template:
✅ Create apex class
With default template:
✅ Create apex class
✅ Create analytics template
✅ Create apex trigger
✅ Create lightning interface
✅ Create LWC
✅ Create LWC Test
✅ Create Aura cmp
✅ Create Aura app
✅ Create Aura event
✅ Create VF page
Failed:
❌ Create VF cmp -> no API version in the meta-xml
❌ Create Project - no sourceApiVersion in the sfdx-project.json
❌ Create Project w/ Manifest - no version set in the package.xml
^^ all should be solved with adding this
to the apiversion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Create VF cmp -> now setting API version in the meta-xml
✅ Create Project - now setting sourceApiVersion
✅ Create Project w/ Manifest - now setting version in the package.xml
What does this PR do?
interface for TemplateOptions has apiVersion and outputDir as optional. But SfdxGenerator is typed to make them required, so catch-22.
This moves those to instance props that are defaulted in the ctor.
unrelated:
shelljs
is only used in some npm script, so it moved to devDepsI bumped
tar
to help with an error related to node18 isaacs/node-tar#321What issues does this PR fix or reference?
needed for @W-11976561@ to remove a bunch of type-ignoring code