Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from lhttpc #17

Closed
andreineculau opened this issue Sep 28, 2015 · 3 comments
Closed

move from lhttpc #17

andreineculau opened this issue Sep 28, 2015 · 3 comments
Milestone

Comments

@andreineculau
Copy link
Member

to

@andreineculau andreineculau added this to the 1.4.0 milestone Oct 20, 2015
@andreineculau andreineculau modified the milestones: 1.4.0, 2.0.0 Nov 20, 2015
andreineculau added a commit that referenced this issue Nov 20, 2015
andreineculau added a commit that referenced this issue Feb 15, 2016
@isakb
Copy link
Contributor

isakb commented Mar 18, 2016

Out of curiosity, what was the actual issue with lhttpc? Anything that didn't work well with it that required a move, or is it outdated or something? (Since a patch with 53 additions and 21 deletions seem like a step in the wrong direction from my point of view - unless the extra code adds some valuable feature that was missing.)

@andreineculau
Copy link
Member Author

from https://github.com/esl/lhttpc "This project is not supported anymore."

Took 1.5 years to merge the simple esl/lhttpc#43, meanwhile we were running on some fork (not a proper lhttpc-next fork, but the fork that had this commit alone)...

The numbers are deceiving though, because the committer (me) chose the least-changes path (not out of being lazy :) but because I wanted #22 to be done before touching more the tests). Similarly, at least 6 lines are just about list-binary conversions, so one could argue "if only KATT was using binaries from the start.."

@isakb
Copy link
Contributor

isakb commented Mar 18, 2016

Fair enough :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants