This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
bcd-update: do not spuriously report modifications #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the return value of `update` is used only to optimize I/O, false positives only degrade efficiency--not correctness. However, the underlying behavior substantively effects the interpretation of the `"mirror"` support value. Due to an unrelated bug (where modifications to mirrored support values are not written back to disk), this error cannot currently be observed. Correct the return value for this condition in order to improve efficiency and prepare for a later correction to the `"mirror"` feature.
foolip
approved these changes
Sep 14, 2022
jugglinmike
added a commit
to bocoup/browser-compat-data
that referenced
this pull request
Sep 28, 2022
These changes were generated procedurally by the mdn-bcd-collector project using data collected from Chrome for Android and following three corrections to its interpretation of the "mirror" support value: foolip/mdn-bcd-collector#2326 foolip/mdn-bcd-collector#2297 foolip/mdn-bcd-collector#2280
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the return value of
updateis used only to optimize I/O, false positives only degrade efficiency--not correctness. However, the underlying behavior substantively effects the interpretation of the"mirror"support value. Due to an unrelated bug (where modifications to mirrored support values are not written back to disk), this error cannot currently be observed.Correct the return value for this condition in order to improve efficiency and prepare for a later correction to the
"mirror"feature.