This repository has been archived by the owner on Sep 26, 2023. It is now read-only.
Ignore Safari backported releases #1572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
foolip
reviewed
Oct 15, 2021
ua-parser.js
Outdated
| @@ -74,6 +74,15 @@ const parseUA = (userAgent, browsers) => { | |||
| const versions = Object.keys(browsers[data.browser.id].releases); | |||
| versions.sort(compareVersions); | |||
|
|
|||
| // Certain Safari versions are backports of newer versions, but contain less | |||
| // features, particularly ones involving OS integration. We will ignore these | |||
There was a problem hiding this comment.
It's not ignored, something is returned. I guess inBcd being false is the important thing?
There was a problem hiding this comment.
Correct -- this allows us to tell the client what browser we've detected and potentially still use the data if we wanted to!
There was a problem hiding this comment.
Can you update the comment to reflect this?
foolip
approved these changes
Oct 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the UA parser to ignore known backported releases of Safari, rather than remapping them to the versions they backport (due to OS integration differences causing some features to report as false) or worse, to their prior versions. This is practically the opposite of #1244.