Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop build_aarch64_wheels job in favor of ubuntu-24.04-arm os #38

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

justvanrossum
Copy link
Contributor

@justvanrossum justvanrossum commented Jan 30, 2025

Derived from fonttools/fonttools@cdf5a6e

This would drop separate macOS x86_64 wheels, in favor of universal2-only. If this isn't desired, I can try to add x86_64 back in. Edit: this was not true

@anthrotype
Copy link
Member

universal2-only

it's probably ok by now

@justvanrossum
Copy link
Contributor Author

Actually, my statement was probably incorrect: perhaps x86_64 is still built. Fingers crossed this first run works at all.

@anthrotype
Copy link
Member

This would drop separate macOS x86_64 wheels, in favor of universal2-only

are you sure? I still see "macos-13" listed and I think that one is native x86_64; in combination with auto64.. you'd still get those I believe

@anthrotype
Copy link
Member

so, with this new upload/download-artifact actions the name of the artifacts need to be unique...

https://github.com/fonttools/openstep-plist/actions/runs/13056828491/job/36429879715?pr=38#step:6:21

@anthrotype
Copy link
Member

see https://github.com/fonttools/fonttools/blob/b467579c8d5a8fd642bb81d5922d650ea267d1b6/.github/workflows/wheels.yml#L80

@anthrotype
Copy link
Member

you know, I think you could keep the old CIBW_ARCHS: auto64 and simply add "ubuntu-24.04-arm" to the matrix' os list... that should mean that cibuildwheel will build aarch64 which is the native 64-bit architecture for a runner like "ubuntu-24.04-arm"... I haven't tried though

@anthrotype
Copy link
Member

and it looks like we weren't building 32-bit windows wheels so far, and nobody bothered.. not sure we should start now?

@justvanrossum
Copy link
Contributor Author

and it looks like we weren't building 32-bit windows wheels so far, and nobody bothered.. not sure we should start now?

Should I then also undo that wheels-${{ matrix.os }}-${{ matrix.arch }} change?

@anthrotype
Copy link
Member

Should I then also undo that wheels-${{ matrix.os }}-${{ matrix.arch }} change?

no it's fine

@justvanrossum
Copy link
Contributor Author

you know, I think you could keep the old CIBW_ARCHS: auto64 and simply add "ubuntu-24.04-arm" to the matrix' os list... that should mean that cibuildwheel will build aarch64 which is the native 64-bit architecture for a runner like "ubuntu-24.04-arm"...

Isn't the CIBW_ARCHS: ${{ matrix.arch }} line crucial to make the matrix.arch stuff work at all?

@anthrotype
Copy link
Member

I mean leaving the old CIBW_ARCHS: auto64 (without parametrizing matrix.arch) might just work for arm64 runner

@anthrotype
Copy link
Member

but yeah, for the unique name of the artifact, you need to define some matrix.arch

i'm ok to leave as is

@justvanrossum
Copy link
Contributor Author

I tried to stay close to what fonttools is doing, and I'm not super comfortable with these kinds of changes to begin with, so if it's ok like this, then 👍

@anthrotype anthrotype merged commit 2fa77b2 into fonttools:master Jan 30, 2025
6 checks passed
@anthrotype
Copy link
Member

I can tag a release or wait if you have any more patches?

@justvanrossum justvanrossum deleted the modernize-aarch64-wheels branch January 30, 2025 17:47
@justvanrossum
Copy link
Contributor Author

A release would be perfect, I have no more patches at this time. Thank you!

@anthrotype
Copy link
Member

I pushed v0.5.0 https://github.com/fonttools/openstep-plist/actions/runs/13058435246

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants