-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop build_aarch64_wheels job in favor of ubuntu-24.04-arm os #38
Drop build_aarch64_wheels job in favor of ubuntu-24.04-arm os #38
Conversation
it's probably ok by now |
Actually, my statement was probably incorrect: perhaps x86_64 is still built. Fingers crossed this first run works at all. |
are you sure? I still see "macos-13" listed and I think that one is native x86_64; in combination with auto64.. you'd still get those I believe |
so, with this new upload/download-artifact actions the name of the artifacts need to be unique... https://github.com/fonttools/openstep-plist/actions/runs/13056828491/job/36429879715?pr=38#step:6:21 |
you know, I think you could keep the old |
and it looks like we weren't building 32-bit windows wheels so far, and nobody bothered.. not sure we should start now? |
Should I then also undo that |
no it's fine |
Isn't the |
I mean leaving the old CIBW_ARCHS: auto64 (without parametrizing matrix.arch) might just work for arm64 runner |
but yeah, for the unique name of the artifact, you need to define some matrix.arch i'm ok to leave as is |
I tried to stay close to what fonttools is doing, and I'm not super comfortable with these kinds of changes to begin with, so if it's ok like this, then 👍 |
I can tag a release or wait if you have any more patches? |
A release would be perfect, I have no more patches at this time. Thank you! |
Derived from fonttools/fonttools@cdf5a6e
This would drop separate macOS x86_64 wheels, in favor of universal2-only. If this isn't desired, I can try to add x86_64 back in.Edit: this was not true