New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix `base_has_width` and add test #5008

Open

bobh0303 wants to merge 1 commit into fonttools:main from bobh0303:fix_base_has_width

Contributor

bobh0303 commented Mar 11, 2025

Description

Fixes concerns raised in #5007

Update checks/base_has_width.py to:

Ignore PUA characters
Reverse the mark class test so that it:
- Ignores glyphs that are in GDEF mark class
- Checks glyphs that are not in the GDEF mark class

and add tests/test_checks_base_has_width.py to verify correct behavior

Checklist

update CHANGELOG.md
wait for the tests to pass
request a review


          fixes fonttools#5007

1c3cc2b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet