Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update com.google.fonts/check/varfont/regular_x_coord checks #4010

Merged
merged 11 commits into from
Jan 17, 2023

Conversation

kaydeearts
Copy link
Contributor

Description

This pull request addresses the problems described at issue #4003 :

Adds a separate test/result code for the case of "no regular instance present". This does not change the outcome of the base test at all, it simply separates the FAIL conditions to enable overriding.
Adobe Fonts profile overrides the following regular coords checks:

  • com.google.fonts/check/varfont/regular_wght_coord
  • com.google.fonts/check/varfont/regular_wdth_coord
  • com.google.fonts/check/varfont/regular_slnt_coord
  • com.google.fonts/check/varfont/regular_ital_coord
  • com.google.fonts/check/varfont/regular_opsz_coord

relaxing FAIL on code no-regular-instance to WARN. If a regular instance is present but its coordinate does not match the expected value specific to the check, it will still FAIL as before.

Note: This is a copy of #4004 , which I closed to try to resolve the CLA issue.

To Do

  • update CHANGELOG.md
  • wait for all checks to pass
  • request a review

@google-cla
Copy link

google-cla bot commented Jan 11, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@kaydeearts
Copy link
Contributor Author

kaydeearts commented Jan 11, 2023

Update: I think we've found a solution, just need to wait till next week to try it out.

If anyone can help with troubleshooting why the CLA bot cannot detect me under the CCLA, please let me know! I've been running into trouble with the Google CLA bot for the last few days, and have emailed cla-submissions@google.com for help. Here's a list of things I've already done to try to resolve this:

  • I've been a member of the adobe google contributors group for a while
  • My primary email is used consistently across my git commits, github account, and the adobe google contributors group.
  • I unchecked Keep my email address private
  • I rescanned the CLA check on the PR multiple times, as well as closed and reopened the PR after checking all of the above.

@guidoferreyra
Copy link
Contributor

Really looking forward to see these changes merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants