Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub action to build and publish a release #3699

Merged
merged 2 commits into from
Apr 20, 2022
Merged

Add GitHub action to build and publish a release #3699

merged 2 commits into from
Apr 20, 2022

Conversation

miguelsousa
Copy link
Contributor

@miguelsousa miguelsousa commented Apr 10, 2022

Adds a GitHub action that builds and publishes a release to PyPI and GH when a tag is pushed.
Fixes #3628

@felipesanches To get this working you'll need to create one GH secret for PYPI_API_TOKEN.
This page describes how to create the secret: https://docs.github.com/en/actions/security-guides/encrypted-secrets
The token itself will need to be generated at https://pypi.org/manage/account/

The GITHUB_TOKEN secret is automatically managed. See https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret

@felipesanches
Copy link
Collaborator

thanks! I'll review this and set it up this week

@miguelsousa
Copy link
Contributor Author

@felipesanches Any progress on this?

@felipesanches
Copy link
Collaborator

I have read the PR and it looks good. Seems reasonable. I have not taken the time to create the secrets yet, but I will do so once I decide to cut the next release. I believe that this will not have any bad side-effect if I merge it right now even before creating the secrets.

Once I cut a new release I also plan to update the Maintainer docs to reflect the new procedure.

@felipesanches felipesanches merged commit d56f803 into fonttools:main Apr 20, 2022
@miguelsousa miguelsousa deleted the msousa-build-publish-action branch April 20, 2022 04:00
felipesanches added a commit to felipesanches/fontbakery that referenced this pull request Jun 16, 2022
to mention that packages are built and published automatically by a
GitHub Action after a version tag is pushed.
(PR fonttools#3699)
felipesanches added a commit to felipesanches/fontbakery that referenced this pull request Jun 16, 2022
to mention that packages are built and published automatically by a
GitHub Action after a version tag is pushed.
(PR fonttools#3699)
felipesanches added a commit that referenced this pull request Jun 16, 2022
to mention that packages are built and published automatically by a
GitHub Action after a version tag is pushed.
(PR #3699)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question: Why no GH releases?
2 participants