Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[check/dotted_circle] Mention fontmake's filter on check rationale #4789

Closed
felipesanches opened this issue Jul 12, 2024 · 0 comments
Closed

[check/dotted_circle] Mention fontmake's filter on check rationale #4789

felipesanches opened this issue Jul 12, 2024 · 0 comments
Assignees
@felipesanches
Labels
Check improvement proposal
Milestone
0.12.9

Comments

@felipesanches
Copy link
Collaborator

@davelab6 suggests updating the fb check FAIL result text to include the fontmake filter one liner that @simoncozens posted:

fontmake --filter 'DottedCircleFilter(pre=True)' --filter '...'
@felipesanches felipesanches self-assigned this Jul 12, 2024
@felipesanches felipesanches modified the milestones: 0.12.9, 0.12.10 Jul 12, 2024
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Jul 17, 2024
@felipesanches
Mention fontmake filter command line on rationale
6e1531c 
com.google.fonts/check/dotted_circle
On Shaping profile.

(issue fonttools#4789)
@felipesanches felipesanches mentioned this issue Jul 17, 2024
Merged
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Jul 17, 2024
@felipesanches
Mention fontmake filter command line on rationale
15a8868 
com.google.fonts/check/dotted_circle
On Shaping profile.

(issue fonttools#4789)
felipesanches added a commit that referenced this issue Jul 17, 2024
@felipesanches
Mention fontmake filter command line on rationale
2bb3b91 
com.google.fonts/check/dotted_circle
On Shaping profile.

(issue #4789)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
Check improvement proposal
Projects
None yet
Milestone
0.12.9
Development

No branches or pull requests
1 participant
@felipesanches