Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML and Markdown reporters are broken #4595

Closed
guidoferreyra opened this issue Mar 14, 2024 · 4 comments
Closed

HTML and Markdown reporters are broken #4595

guidoferreyra opened this issue Mar 14, 2024 · 4 comments
Assignees
@felipesanches
Labels
P0 Urgent
Milestone
0.12.0

Comments

@guidoferreyra
Copy link
Contributor

guidoferreyra commented Mar 14, 2024 •
edited by felipesanches
Loading

The original title of this issue was: "HTML reporter is broken for FAIL results"

Observed behaviour

All the FAIL checks are being being ommited on the HTML report. See image.

imagen

Other checks that produces WARNS or ERROR are displayed correctly
@glenda-tn
Copy link

This is also broken for WARNS.

@felipesanches felipesanches added this to the 0.12.0 milestone Mar 15, 2024
@m4rc1e
Copy link
Collaborator

m4rc1e commented Mar 15, 2024 •
edited
Loading

Broken all round I'm afraid, google/fonts#7384 (comment)

Since this has broken a few times now, it's probably worth writing a unit test.

@felipesanches
Copy link
Collaborator

Ouch! Sorry for that!

I'll try to fix it as quickly as possible

felipesanches added a commit to felipesanches/fontbakery that referenced this issue Mar 15, 2024
@felipesanches
fix markdown reporter
b5da6a6 
(issue fonttools#4595)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Mar 15, 2024
@felipesanches
fix markdown/html reporters
346d76a 
(issue fonttools#4595)
felipesanches added a commit to felipesanches/fontbakery that referenced this issue Mar 15, 2024
@felipesanches
fix markdown/html reporters
52baba3 
(issue fonttools#4595)
@felipesanches felipesanches mentioned this issue Mar 15, 2024
Merged
@felipesanches felipesanches self-assigned this Mar 15, 2024
@felipesanches felipesanches changed the title HTML reporter is broken for FAIL results HTML and Markdown reporters are broken Mar 15, 2024
felipesanches added a commit that referenced this issue Mar 15, 2024
@felipesanches
fix markdown/html reporters
0aa38f3 
(issue #4595)
@guidoferreyra
Copy link
Contributor Author

On my local clone of the repo I still don’t see the FAILS 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@felipesanches felipesanches

Labels
P0 Urgent
Projects
None yet
Milestone
0.12.0
Development

No branches or pull requests
4 participants
@felipesanches @guidoferreyra @m4rc1e @glenda-tn