-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache gem install fontist
, cache ~/.fontist
, and add semver support
#6
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
gem install fontist
gem install fontist
& cache ~/.fontist
gem install fontist
& cache ~/.fontist
gem install fontist
gem install fontist
gem install fontist
& cache ~/.fontist
gem install fontist
& cache ~/.fontist
gem install fontist
, cache ~/.fontist
, and add semver support
Thank you @jcbhmr for this! @CAMOBAP @alexeymorozov could you please help review and merge this? Thanks! |
@@ -23,9 +23,13 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
os: [ubuntu-latest, macos-latest, windows-latest] | |||
# os: [ubuntu-latest, macos-latest, windows-latest] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there some issues on Windows discovered?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's because bun
is not supported on Windows.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job!
Few minor comments added
Thank you @jcbhmr ! |
@CAMOBAP we can probably start using this action for our Metanorma actions! |
This PR would:
cache: true
and if no tool cache, try to restore from workflow cachegem install fontist
with custom--install-dir
to avoid contaminating user's rubygems install locationfontist
andfontist.cmd
scripts which proxy to the--install-dir
location with some magic env vars set to load the library.rb
files from the--install-dir
instead of the global default spotcache: true
and no cache content then try to stash in cachefix #9
fix #8
fix #7
fix #1
basically does a good amount of caching and adds semver version support