Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Malt.jl by default on all systems #2767

Merged
merged 4 commits into from
Jan 23, 2024
Merged

Enable Malt.jl by default on all systems #2767

merged 4 commits into from
Jan 23, 2024

Conversation

fonsp
Copy link
Owner

@fonsp fonsp commented Jan 3, 2024

This PR enables #2240 on all systems!

This completes the gradual roll-out of the new feature, everything went great!

Copy link
Contributor

github-actions bot commented Jan 3, 2024

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="enable-malt-by-default")
julia> using Pluto

@PallHaraldsson
Copy link

Why is it that "Linux and MacOS will work best" (in README, added there 3 years ago)? Is it because you couldn't interrupt on Windows but now can (because of Malt)? Is Malt at least as good on all platforms? And if no other Windows Pluto issues, drop that outdated caveat?

@fonsp
Copy link
Owner Author

fonsp commented Jan 11, 2024

@PallHaraldsson That's totally true, thanks for the comment! We can remove it now

@fonsp fonsp merged commit 2879cfe into main Jan 23, 2024
14 checks passed
@fonsp fonsp deleted the enable-malt-by-default branch January 23, 2024 12:44
@PallHaraldsson
Copy link

The something could now be one one line:

elseif something(session.options.evaluation.workspace_use_distributed_stdlib, false)
        Malt.DistributedStdlibWorker

maybe more readable, I wasn't familiar with it, and also is it for sure needed, i.e. can you (for sure) expect nothing returned?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants