Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

label + .ui.checkbox #825

Merged
merged 1 commit into from
Jul 10, 2019
Merged

label + .ui.checkbox #825

merged 1 commit into from
Jul 10, 2019

Conversation

GammaGames
Copy link
Contributor

Description

Make the top margin for checkboxes smaller when there's a label

Testcase

https://jsfiddle.net/1kobehda/

Screenshot (when possible)


image

Closes

#823

exoego
exoego approved these changes Jun 20, 2019
View reviewed changes
Copy link
Contributor

@exoego exoego left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I found this PR was initially targeted into master branch, so changed it to develop.
We at FUI basically merge PRs to develop branch while development phase.
And master branch is used for publishing.

@exoego exoego added lang/css Anything involving CSS 🐛 bugfix labels Jun 20, 2019
@exoego exoego changed the base branch from master to develop June 20, 2019 03:39
lubber-de
lubber-de approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@lubber-de lubber-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lubber-de lubber-de added this to the 2.7.7 milestone Jun 20, 2019
@lubber-de lubber-de added the state/awaiting-reviews Pull requests which are waiting for reviews label Jun 20, 2019
GammaGames
GammaGames commented Jun 20, 2019
View reviewed changes
Copy link
Contributor Author

@GammaGames GammaGames left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found this PR was initially targeted into master branch, so changed it to develop.

Oops, my bad! Thank you

y0hami
y0hami approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@y0hami y0hami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@exoego exoego added type/bug Any issue which is a bug or PR which fixes a bug and removed 🐛 bugfix labels Jun 23, 2019
@y0hami y0hami merged commit 2eaaff1 into fomantic:develop Jul 10, 2019
@lubber-de lubber-de removed the state/awaiting-reviews Pull requests which are waiting for reviews label Jul 10, 2019
@y0hami
Copy link
Member

y0hami commented Aug 27, 2019

@all-contributors please add @GammaGames for code

@allcontributors allcontributors bot mentioned this pull request Aug 27, 2019
Merged
@allcontributors
Copy link
Contributor

@hammy2899

I've put up a pull request to add @GammaGames! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exoego exoego exoego approved these changes

@y0hami y0hami y0hami approved these changes

@lubber-de lubber-de lubber-de approved these changes

@ColinFrick ColinFrick Awaiting requested review from ColinFrick

@prudho prudho Awaiting requested review from prudho

Assignees
No one assigned
Labels
lang/css Anything involving CSS type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.7
Development

Successfully merging this pull request may close these issues.
4 participants
@GammaGames @y0hami @exoego @lubber-de