Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As discussed in #2407 this PR renames
header
toheading
..ui.header
selectors to.ui.heading
@header...
LESS variables to@heading...
heading
as well (so header.less and header.variables dont exists anymore)A new variation variable is introduced:
@variationHeadingLegacyHeader
(default false)When set to true, it will generate the old
.header
classes in addition to the.heading
classes for easier migration (but will double all selectors which increases css filesize)This is a HUGE BREAKING CHANGE as
@header...
variables as those do not exist anymoretheme.config
and each customsemantic.json
header
usages are replaced byheading
class usagesStill to be decided / taken into consideration
I leave this PR as draft for now as we still have to check/decide how to deal with other "header" usages in other components:
th
tag in a table is still a "header", not a "heading". However the table component shares the same@heading
variables as the heading element itself. This is inconsistent, i think there are dedicated new variables neededheader
(which either is a "heading", a "title" or still a "header"If this gets merged, we may announce all upcoming breaking changes (espcially this one) long before 2.10.0 gets released, so people are prepared.