fix(dropdown): fix simple upward variant #2219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
lubber-de
removed
the
state/awaiting-reviews
lubber-de
added a commit
that referenced
this pull request
Nov 20, 2022
This partly reverts #2219 and only adds the overflow setting in case of a simple selection dropdown where a possible scrollbar is only needed. Since 2.9.0 a simple menu item dropdown unfortunately also applied a scrollbar, which is wrong. This PR also fixes upward menu positioning in case a floating simple upward dropdown is used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
simple dropdowncss only variant was broken when trying to use it with aupwardmenuTestcase
Fixed
https://jsfiddle.net/lubber/cz09kaue/1/
Broken
https://jsfiddle.net/lubber/cz09kaue/3/
Screenshot
Closes
Semantic-Org/Semantic-UI#6288