[Calendar] Add ability to disable days of week #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudho
added
type/feat
lubber-de
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
Great addition, we should consider doing this for single dates also. So another option settings.disabledDates could hold an array of to be disabled date-objects.
There already is the undocumented (!) isDisabled function in the settings (which always return false), but this needs to provide a whole function logic.
I'll create an issue for you 😄 but the implementation will be at the exact same code-lines.
Anyway this PR itself LGTM
lubber-de
removed
the
state/awaiting-reviews
This was referenced Oct 28, 2018
lubber-de
removed
the
state/awaiting-docs
lubber-de
added
the
state/has-docs
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR add the ability to disable some days of the week from selection. By setting
disabledDaysOfWeekto array of numbers (0= Sunday, 1=Monday...), you can now disallow users from selecting these days.Screenshot
disabledDaysOfWeek: [0, 3, 6]