fix(icon): Change two-word aliases into one-word aliases to avoid conflictions #1636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…flictions The two-word aliases for `chart line` and `line graph` are renamed into one-word aliases `chartline` and `linegraph` respectively to avoid conflicting with the class name `line` which is used by other FUI components. Closes: fomantic#1619
auto-assign
bot
requested review from
ColinFrick,
exoego,
y0hami,
lubber-de and
prudho
exoego
approved these changes
Aug 10, 2020
lubber-de
added
lang/css
ColinFrick
approved these changes
Aug 10, 2020
lubber-de
removed
the
state/awaiting-reviews
lubber-de
added a commit
that referenced
this pull request
Aug 11, 2020
…ompatibility This PR re-adds the two word icon names for chartline and linegraph as of #1636 to avoid being a breaking change as @prudho mentioned here . The next full font awesome update will happen in 2.9.0 using the fixes from fomantic/create-fomantic-icons#115 Then two word aliases will be completely removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The two-word aliases for
chart lineandline graphare renamed into one-word aliaseschartlineandlinegraphrespectively to avoid conflicting with the class namelinewhich is used by other FUI components.Testcase
Broken: https://jsfiddle.net/tqmab8vu/1/
Fixed: https://jsfiddle.net/85mw6can/
Closes
#1619
Semantic-Org/Semantic-UI-React#4392