fix(dropdown): do not use value as name when name is empty #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lubber-de
added
type/bug
ColinFrick
approved these changes
Dec 11, 2019
y0hami
changed the title
lubber-de
added
tag/next-release/nightly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #1112 a missing name of an selection option was fetched and replaced by the value instead when converting select tags into dropdowns.
But this is not the same behavior as for a usual html select where a missing name is rendered as an empty select entry (which of course still has its individual value)
Testcase
The first entry has a value but an empty name. Standard html select would keep the empty name, while...
Broken
... FUI replaces it with the value by default
https://jsfiddle.net/mons57e2/
Fixed
... keeps an empty/non-existing name
https://jsfiddle.net/4oxpwhv2/
Closes
#1191