Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Calendar] startCalendar and endCalendar as selectors #685

Closed
Thanty opened this issue Apr 23, 2019 · 3 comments
Closed

[Calendar] startCalendar and endCalendar as selectors #685

Thanty opened this issue Apr 23, 2019 · 3 comments
Assignees
@lubber-de
Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Milestone
2.7.5

Comments

@Thanty
Copy link

Thanty commented Apr 23, 2019 •
edited
Loading

Bug Report

Docs said we can use selectors when using startCalendar and endCalendar settings.

jQuery object or selector for another calendar that represents the start date of a date range

But this works as expected only when using jQuery objects.

Expected result

Same when using jQuery objects.

Testcase

https://jsfiddle.net/ue9hy7vL/

Version

2.7.4
@lubber-de lubber-de self-assigned this Apr 23, 2019
@lubber-de lubber-de added type/bug Any issue which is a bug or PR which fixes a bug lang/javascript Anything involving JavaScript labels Apr 23, 2019
@lubber-de lubber-de added this to the 2.7.5 milestone Apr 23, 2019
@lubber-de lubber-de mentioned this issue Apr 23, 2019
Merged
@lubber-de
Copy link
Member

Fixed by #687
See your adjusted jsfiddle here: https://jsfiddle.net/c83kypx1/

@Thanty
Copy link
Author

Thanty commented Apr 24, 2019

Fixed by #687
See your adjusted jsfiddle here: https://jsfiddle.net/c83kypx1/

lubber-de, thanks for the hotfix! I wonder was there a reason in searching only child elements?

@lubber-de
Copy link
Member

lubber-de commented Apr 24, 2019 •
edited
Loading

@Thanty I looked into the commit log of the repo where we merged the module from , but there is nothing i can explain from there. Maybe the testcases at that time did not cover form field embeddings.

@lubber-de lubber-de added the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Apr 26, 2019
exoego pushed a commit to exoego/Fomantic-UI that referenced this issue Apr 30, 2019
@lubber-de
fix(calendar): string selectors for start/endCalendar did not work
7af938a 
In case the startCalendar/endCalendar settings were given as string (which basically was supported) the current code assumes the selector would have the same parent as the opposite calendar, which is not even true in the docs-example (where each calendar is inside a form div)
This PR now corrects this, so it is using the given string selector as expected searching in the whole document

Closes fomantic#685
@y0hami y0hami closed this as completed in 9604a02 May 16, 2019
@lubber-de lubber-de removed the tag/next-release/nightly Any issue which has a corresponding PR which has been merged and is available in the nightly build label Jun 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lubber-de lubber-de

Labels
lang/javascript Anything involving JavaScript type/bug Any issue which is a bug or PR which fixes a bug
Projects
None yet
Milestone
2.7.5
Development

No branches or pull requests
2 participants
@Thanty @lubber-de